Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: utoipa for /layers #5809

Merged
merged 1 commit into from
Nov 23, 2023
Merged

editoast: utoipa for /layers #5809

merged 1 commit into from
Nov 23, 2023

Conversation

Tristramg
Copy link
Contributor

Ref #4580

@Tristramg Tristramg requested a review from a team as a code owner November 22, 2023 16:24
@Tristramg Tristramg self-assigned this Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6958130) 19.61% compared to head (86ca59b) 19.61%.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5809      +/-   ##
============================================
- Coverage     19.61%   19.61%   -0.01%     
  Complexity     2332     2332              
============================================
  Files           907      907              
  Lines        107662   107654       -8     
  Branches       2623     2623              
============================================
- Hits          21120    21112       -8     
  Misses        84986    84986              
  Partials       1556     1556              
Flag Coverage Δ
front 8.59% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@younesschrifi younesschrifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! An omission and a suggestion:

editoast/openapi_legacy.yaml Outdated Show resolved Hide resolved
editoast/src/views/layers/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Tristramg Tristramg added this pull request to the merge queue Nov 23, 2023
Merged via the queue into dev with commit 6e89696 Nov 23, 2023
@Tristramg Tristramg deleted the utoipa-layers branch November 23, 2023 08:03
bougue-pe added a commit that referenced this pull request Nov 23, 2023
Follow-up on #5809
This fixes broken editoast test.
bougue-pe added a commit that referenced this pull request Nov 23, 2023
Follow-up on #5809
This fixes broken editoast test.
github-merge-queue bot pushed a commit that referenced this pull request Nov 23, 2023
Follow-up on #5809
This fixes broken editoast test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants