Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: fix /layers endpoint #5816

Merged
merged 1 commit into from
Nov 23, 2023
Merged

editoast: fix /layers endpoint #5816

merged 1 commit into from
Nov 23, 2023

Conversation

bougue-pe
Copy link
Contributor

Follow-up on #5809
This fixes broken editoast test.

Follow-up on #5809
This fixes broken editoast test.
@bougue-pe bougue-pe requested a review from a team as a code owner November 23, 2023 11:09
Copy link
Contributor

@Tristramg Tristramg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for fixing my mistakes!

Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we missed the failing CI 😓 Thanks for the fix!

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2019297) 19.60% compared to head (e3a2606) 19.61%.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #5816   +/-   ##
=========================================
  Coverage     19.60%   19.61%           
  Complexity     2332     2332           
=========================================
  Files           907      907           
  Lines        107685   107693    +8     
  Branches       2623     2623           
=========================================
+ Hits          21116    21125    +9     
+ Misses        85013    85012    -1     
  Partials       1556     1556           
Flag Coverage Δ
editoast 68.10% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bougue-pe bougue-pe added this pull request to the merge queue Nov 23, 2023
Merged via the queue into dev with commit 8ddf0c8 Nov 23, 2023
10 checks passed
@bougue-pe bougue-pe deleted the peb/fix_editoast_tests branch November 23, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants