Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: rename v2 components #8781

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

SharglutDev
Copy link
Contributor

@SharglutDev SharglutDev commented Sep 5, 2024

It does not handle stdcmV2 renaming as it still coexists with stdcm debug

close #7029

Some refacto regarding drop won't be included in the PR but issues have been created :

To test :

  • no more v2 folder
  • no more v2 components (except stdcm)
  • no more v2 variables/functions (except stdcm)
  • no more TODO DROP V1 / drop v1 in the app
  • app is still "working"

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 10.02278% with 395 lines in your changes missing coverage. Please review.

Project coverage is 37.02%. Comparing base (adfc67c) to head (bc00cf2).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...ons/operationalStudies/views/SimulationResults.tsx 0.00% 21 Missing ⚠️
.../operationalStudiesConf/powerRestrictionReducer.ts 39.39% 20 Missing ⚠️
...les/pathfinding/components/Itinerary/Itinerary.tsx 0.00% 18 Missing ⚠️
...components/SpaceCurvesSlopes/SpaceCurvesSlopes.tsx 0.00% 14 Missing ⚠️
...applications/operationalStudies/views/Scenario.tsx 0.00% 11 Missing ⚠️
...s/operationalStudies/views/ManageTrainSchedule.tsx 0.00% 10 Missing ⚠️
...ion/hooks/usePowerRestrictionSelectorBehaviours.ts 0.00% 9 Missing ⚠️
...ront/src/reducers/osrdconf/osrdConfCommon/index.ts 55.00% 1 Missing and 8 partials ⚠️
front/src/applications/stdcm/views/StdcmConfig.tsx 0.00% 8 Missing ⚠️
...ents/SimulationResultsMap/SimulationResultsMap.tsx 0.00% 8 Missing ⚠️
... and 73 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8781      +/-   ##
============================================
- Coverage     37.03%   37.02%   -0.01%     
  Complexity     2212     2212              
============================================
  Files          1253     1253              
  Lines        113926   113884      -42     
  Branches       3188     3188              
============================================
- Hits          42191    42171      -20     
+ Misses        69839    69817      -22     
  Partials       1896     1896              
Flag Coverage Δ
core 74.79% <ø> (ø)
editoast 72.39% <ø> (-0.03%) ⬇️
front 14.95% <10.02%> (-0.02%) ⬇️
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev SharglutDev force-pushed the pfn/front/rename-v2-components branch from db29206 to 338b681 Compare September 6, 2024 09:54
@SharglutDev SharglutDev marked this pull request as ready for review September 6, 2024 10:08
@SharglutDev SharglutDev requested a review from a team as a code owner September 6, 2024 10:08
@SharglutDev SharglutDev force-pushed the pfn/front/rename-v2-components branch from 338b681 to 1d75be4 Compare September 6, 2024 10:19
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@SharglutDev SharglutDev force-pushed the pfn/front/rename-v2-components branch from 1d75be4 to 67e1614 Compare September 10, 2024 07:01
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!! Tested

@SharglutDev SharglutDev added this pull request to the merge queue Sep 10, 2024
@SharglutDev SharglutDev removed this pull request from the merge queue due to a manual request Sep 10, 2024
@SharglutDev SharglutDev added this pull request to the merge queue Sep 10, 2024
@SharglutDev SharglutDev removed this pull request from the merge queue due to a manual request Sep 10, 2024
@SharglutDev SharglutDev added this pull request to the merge queue Sep 10, 2024
@SharglutDev SharglutDev removed this pull request from the merge queue due to a manual request Sep 10, 2024
It does not handle stdcmV2 renaming as it still coexists with stdcm debug

Signed-off-by: SharglutDev <[email protected]>
@SharglutDev SharglutDev force-pushed the pfn/front/rename-v2-components branch from 67e1614 to bc00cf2 Compare September 10, 2024 11:39
@SharglutDev SharglutDev added this pull request to the merge queue Sep 10, 2024
Merged via the queue into dev with commit 950a5b1 Sep 10, 2024
24 checks passed
@SharglutDev SharglutDev deleted the pfn/front/rename-v2-components branch September 10, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: rename all the components v2
4 participants