-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: add speed space chart e2e test #9829
Conversation
7ce7004
to
fdc276e
Compare
fdc276e
to
6fbebea
Compare
Review & tested, looking good |
btw, the fixup fa8fd20 should not go in the readme commit |
Yes my bad , I will fix that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one thing that may be important:
when the tests are launched, snapshots are created with the name you give, but three times each with -chromium-linux.png
or -firefox-linux.png
added, so we have yet 16 png files, when I launch them on macos, playwright generates 16 new files with -chromium-darwin.png
or -firefox-darwin.png
Good catch! I think we can add a control to run the snapshot assertion only on Linux. The method toHaveScreenshot() generates images based on the operating system and browser, and we can't maintain multiple screenshots for every OS and browser combination |
that's the wisest solution I think |
d3f1e72
to
6547ce6
Compare
98c0067
to
23232b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a lot better, thanks for fixing the comments! Here are a few more.
71bafdb
to
7eb1561
Compare
3e976bf
to
ac4f85a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still one remaining comment for a small cleanup: #9829 (comment)
If you're not willing to do it, you can resolve it.
Thanks!
ac4f85a
to
b561f13
Compare
b561f13
to
3558310
Compare
3558310
to
914b7bd
Compare
914b7bd
to
a32dc66
Compare
Signed-off-by: maymanaf <[email protected]>
a32dc66
to
5edb36e
Compare
Signed-off-by: maymanaf <[email protected]>
5edb36e
to
9db7dc6
Compare
Closes #8651
The visual assertion using the snapshot is only performed on Chrome due to issue #9909