Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add speed space chart e2e test #9829

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

Maymanaf
Copy link
Contributor

@Maymanaf Maymanaf commented Nov 22, 2024

Closes #8651
The visual assertion using the snapshot is only performed on Chrome due to issue #9909

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 22, 2024
@Maymanaf Maymanaf force-pushed the aba/e2e-gev-snapshot-test branch 7 times, most recently from 7ce7004 to fdc276e Compare November 26, 2024 08:49
@Maymanaf Maymanaf marked this pull request as ready for review November 26, 2024 08:49
@Maymanaf Maymanaf requested a review from a team as a code owner November 26, 2024 08:50
@Maymanaf Maymanaf force-pushed the aba/e2e-gev-snapshot-test branch from fdc276e to 6fbebea Compare November 27, 2024 09:29
front/playwright.config.ts Outdated Show resolved Hide resolved
front/tests/pages/op-simulation-results-page-model.ts Outdated Show resolved Hide resolved
front/tests/012-op-simulation-settings-tab.spec.ts Outdated Show resolved Hide resolved
@Maymanaf Maymanaf requested a review from a team as a code owner November 27, 2024 16:13
@anisometropie
Copy link
Contributor

Review & tested, looking good

@Maymanaf Maymanaf requested a review from kmer2016 November 28, 2024 08:45
@anisometropie
Copy link
Contributor

btw, the fixup fa8fd20 should not go in the readme commit

@Maymanaf
Copy link
Contributor Author

btw, the fixup fa8fd20 should not go in the readme commit

Yes my bad , I will fix that

Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing that may be important:

when the tests are launched, snapshots are created with the name you give, but three times each with -chromium-linux.png or -firefox-linux.png added, so we have yet 16 png files, when I launch them on macos, playwright generates 16 new files with -chromium-darwin.png or -firefox-darwin.png

@Maymanaf
Copy link
Contributor Author

one thing that may be important:

when the tests are launched, snapshots are created with the name you give, but three times each with -chromium-linux.png or -firefox-linux.png added, so we have yet 16 png files, when I launch them on macos, playwright generates 16 new files with -chromium-darwin.png or -firefox-darwin.png

Good catch! I think we can add a control to run the snapshot assertion only on Linux. The method toHaveScreenshot() generates images based on the operating system and browser, and we can't maintain multiple screenshots for every OS and browser combination
What do you think ?

@Yohh
Copy link
Contributor

Yohh commented Nov 28, 2024

that's the wisest solution I think

@Maymanaf Maymanaf force-pushed the aba/e2e-gev-snapshot-test branch 6 times, most recently from d3f1e72 to 6547ce6 Compare December 3, 2024 10:52
@Maymanaf Maymanaf force-pushed the aba/e2e-gev-snapshot-test branch 3 times, most recently from 98c0067 to 23232b8 Compare December 10, 2024 09:37
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

front/README.md Outdated Show resolved Hide resolved
front/tests/pages/op-simulation-results-page-model.ts Outdated Show resolved Hide resolved
front/tests/012-op-simulation-settings-tab.spec.ts Outdated Show resolved Hide resolved
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot better, thanks for fixing the comments! Here are a few more.

front/tests/pages/common-page-model.ts Outdated Show resolved Hide resolved
front/README.md Outdated Show resolved Hide resolved
front/README.md Outdated Show resolved Hide resolved
@Maymanaf Maymanaf force-pushed the aba/e2e-gev-snapshot-test branch 2 times, most recently from 71bafdb to 7eb1561 Compare December 13, 2024 12:21
@Maymanaf Maymanaf requested a review from emersion December 13, 2024 14:28
@Maymanaf Maymanaf force-pushed the aba/e2e-gev-snapshot-test branch 2 times, most recently from 3e976bf to ac4f85a Compare December 13, 2024 16:54
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still one remaining comment for a small cleanup: #9829 (comment)

If you're not willing to do it, you can resolve it.

Thanks!

@Maymanaf Maymanaf force-pushed the aba/e2e-gev-snapshot-test branch from ac4f85a to b561f13 Compare December 16, 2024 10:43
@Maymanaf Maymanaf enabled auto-merge December 16, 2024 10:46
@Maymanaf Maymanaf force-pushed the aba/e2e-gev-snapshot-test branch from b561f13 to 3558310 Compare December 16, 2024 10:49
@Maymanaf Maymanaf disabled auto-merge December 16, 2024 11:00
@Maymanaf Maymanaf force-pushed the aba/e2e-gev-snapshot-test branch from 3558310 to 914b7bd Compare December 16, 2024 12:24
@Maymanaf Maymanaf enabled auto-merge December 16, 2024 12:24
@Maymanaf Maymanaf disabled auto-merge December 16, 2024 13:49
@Maymanaf Maymanaf force-pushed the aba/e2e-gev-snapshot-test branch from 914b7bd to a32dc66 Compare December 16, 2024 14:45
@Maymanaf Maymanaf force-pushed the aba/e2e-gev-snapshot-test branch from a32dc66 to 5edb36e Compare December 16, 2024 14:50
@Maymanaf Maymanaf force-pushed the aba/e2e-gev-snapshot-test branch from 5edb36e to 9db7dc6 Compare December 16, 2024 15:15
@Maymanaf Maymanaf added this pull request to the merge queue Dec 16, 2024
Merged via the queue into dev with commit 70e728e Dec 16, 2024
27 checks passed
@Maymanaf Maymanaf deleted the aba/e2e-gev-snapshot-test branch December 16, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: GEV e2e tests
4 participants