Rework HTTP/JSON handling to be cleaner #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhvrc
added
type: optimization
in: serial
hhvrc
changed the title
redmushie
reviewed
Nov 7, 2023
hhvrc
added a commit
that referenced
this pull request
Nov 27, 2023
* develop: (29 commits) build(deps-dev): Bump the npm-dependencies group in /WebUI with 11 updates (#127) Remove loop() behaviour from code (#123) Check if link code is proper length + use numeric input (#124) RGB Support plus OpenShock Core V1 board definition (#121) Increase stability by handling heavy tasks better (#122) D1 Mini default pin should be 15 Rework HTTP/JSON handling to be cleaner (#106) Push color palette (#118) build(deps-dev): Bump the npm-dependencies group in /WebUI with 9 updates (#117) build(deps-dev): Bump the npm-dependencies group (#116) Decrease cache to 1 hour (#115) Fix captive portal not showing network savestate + forget functionality (#113) Improve git commit hash CPP define (#110) Conform EStopManager to code style (#109) More code cleanup (#107) Bugfix/shocker unpaired randomly (#105) Some more code cleanup (#104) Fix serial WiFi configuration not working (#102) Better captive portal logging (#103) Add http caching with filesystem hash to reduce load on esp (#101) ...
hhvrc
added a commit
that referenced
this pull request
Nov 27, 2023
* develop: (48 commits) build(deps-dev): Bump the npm-dependencies group in /WebUI with 11 updates (#127) Remove loop() behaviour from code (#123) Check if link code is proper length + use numeric input (#124) RGB Support plus OpenShock Core V1 board definition (#121) Increase stability by handling heavy tasks better (#122) D1 Mini default pin should be 15 Rework HTTP/JSON handling to be cleaner (#106) Push color palette (#118) build(deps-dev): Bump the npm-dependencies group in /WebUI with 9 updates (#117) build(deps-dev): Bump the npm-dependencies group (#116) Decrease cache to 1 hour (#115) Fix captive portal not showing network savestate + forget functionality (#113) Improve git commit hash CPP define (#110) Conform EStopManager to code style (#109) More code cleanup (#107) Bugfix/shocker unpaired randomly (#105) Some more code cleanup (#104) Fix serial WiFi configuration not working (#102) Better captive portal logging (#103) Add http caching with filesystem hash to reduce load on esp (#101) ...
LucHeart
pushed a commit
that referenced
this pull request
Jan 22, 2024
* Remove ArduinoJson dependency * Add Json helper class * More code cleanup * Improve useragent * Improve Json parsing and file structure * [WIP] Implement ratelimiting and improve interface * Group JsonAPI calls into common place * Fix assignLCG endpoint url * Add response code handling * Improve Json deserializer logging * Finish ratelimiter implementation * Forgot to remove debug stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another step in the direction of getting rid of the arduino framework.
This is just the implementation, steps can be taken to make the interface alot better.
We could implement a C++ wrapper for the C methods.