RGB Support plus OpenShock Core V1 board definition #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhvrc
requested changes
Nov 23, 2023
hhvrc
reviewed
Nov 23, 2023
|
So, we seem to have (mostly?) mitigated the RGB crashing on ESP32-S3 boards. But there has not been enough testing, especially for base ESP32 (dual core) and ESP32-C (single core!!) chips. If there are issues with those, we should consider exploring the RMT Hub option we discussed earlier. (Also yay I figured out how to get around the issues for my board for now.) Otherwise, good to go! |
hhvrc
added a commit
that referenced
this pull request
Nov 27, 2023
* develop: (29 commits) build(deps-dev): Bump the npm-dependencies group in /WebUI with 11 updates (#127) Remove loop() behaviour from code (#123) Check if link code is proper length + use numeric input (#124) RGB Support plus OpenShock Core V1 board definition (#121) Increase stability by handling heavy tasks better (#122) D1 Mini default pin should be 15 Rework HTTP/JSON handling to be cleaner (#106) Push color palette (#118) build(deps-dev): Bump the npm-dependencies group in /WebUI with 9 updates (#117) build(deps-dev): Bump the npm-dependencies group (#116) Decrease cache to 1 hour (#115) Fix captive portal not showing network savestate + forget functionality (#113) Improve git commit hash CPP define (#110) Conform EStopManager to code style (#109) More code cleanup (#107) Bugfix/shocker unpaired randomly (#105) Some more code cleanup (#104) Fix serial WiFi configuration not working (#102) Better captive portal logging (#103) Add http caching with filesystem hash to reduce load on esp (#101) ...
hhvrc
added a commit
that referenced
this pull request
Nov 27, 2023
* develop: (48 commits) build(deps-dev): Bump the npm-dependencies group in /WebUI with 11 updates (#127) Remove loop() behaviour from code (#123) Check if link code is proper length + use numeric input (#124) RGB Support plus OpenShock Core V1 board definition (#121) Increase stability by handling heavy tasks better (#122) D1 Mini default pin should be 15 Rework HTTP/JSON handling to be cleaner (#106) Push color palette (#118) build(deps-dev): Bump the npm-dependencies group in /WebUI with 9 updates (#117) build(deps-dev): Bump the npm-dependencies group (#116) Decrease cache to 1 hour (#115) Fix captive portal not showing network savestate + forget functionality (#113) Improve git commit hash CPP define (#110) Conform EStopManager to code style (#109) More code cleanup (#107) Bugfix/shocker unpaired randomly (#105) Some more code cleanup (#104) Fix serial WiFi configuration not working (#102) Better captive portal logging (#103) Add http caching with filesystem hash to reduce load on esp (#101) ...
LucHeart
pushed a commit
that referenced
this pull request
Jan 22, 2024
* Basic WS2812B Implementation, set by -DOPENSHOCK_LED_WS2812B * Add OpenShock Core V1 definition, allow GPIO+RGB LEDs simultaneously, RGB Tweaks * Add N8R2 chip variant files * Use proper N8R2 board definition partitions * Actually fix partitions, resolve conversations (but there's issues?) * Forgot pdMS_TO_TICKS is a compile-time macro * Attempt defer RGBRMT to Core 0, redo pdMS_TO_TICKs, truly fix partitions * Send black on RGB init, Core V1: standard partitions for now + no PSRAM * Use bitCount for rmt_data_t array, remove initial black send.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes building binaries for my board!
https://github.com/nullstalgia/OpenShock-Hardware/tree/main/Core
<3
Tweaks to Visual State Manager:
LED during boot is now 3 -> 2 -> 1
3 blinks - WiFi not yet connected
2 blinks - Not yet connected to API
1 blink - All Clear!
When you have GPIO LED + RGB, the GPIO LED is relegated to a simple "All Clear" LED, so we can use RGB for more complex stuff down the line (I plan on adding RF output blinks to the LEDs eventually).