Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Case insensitive Sort Order #306

Open
TimidScript opened this issue Aug 20, 2014 · 9 comments
Open

Case insensitive Sort Order #306

TimidScript opened this issue Aug 20, 2014 · 9 comments
Labels
bug You've guessed it... this means a bug is reported. DB Pertains inclusively to the Database operations. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. migration Use this to indicate that it may apply to an existing or announced migration. needs testing Anyone can add this but it is primarily there for the Assignee indicating that Testers are wanted.

Comments

@TimidScript
Copy link

TimidScript commented Aug 20, 2014 •
edited by Martii
Loading

Sort order should be case sensitive and would be nice if it reflects an order similar to windows listing or Greasy Fork. Brackets and characters like * ! ; @ should come before alphanumeric characters.

  • Ability to Sort order Groups by size. (MARTII EDIT) ... already present (/MARTII EDIT)
@jerone
Copy link
Contributor

jerone commented Aug 21, 2014

Sort order should be case sensitive

Sorting is case sensitive right now (uppercase before lowercase).
I'm more leaning to use an case insensitive order. This is more user friendly as script names aren't required to start with a uppercase.

Brackets and characters like * ! ; @ should come before alphanumeric characters

Don't know about this one. Can you give a reason why...

Ability to Sort order Groups by size

@sizzlemctwizzle I scanned the whole source and found that sorting is only possible by properties in the model schemes. size is a custom defined property in the groups. Can you suggest a way around this...

Related issue #292 & PR #309

@Zren
Copy link
Contributor

Zren commented Aug 21, 2014

Ability to Sort order Groups by size.

Requires a new property in the Group schema. There's no way around that.

@jerone
Copy link
Contributor

jerone commented Aug 21, 2014

@Zren commented on 21 aug. 2014 20:06 CEST:

Ability to Sort order Groups by size.

Requires a new property in the Group schema. There's no way around that.

That's what I thought :(

@jerone jerone mentioned this issue Aug 21, 2014
Merged
@TimidScript
Copy link
Author

@jerone

Don't know about this one. Can you give a reason why...

In MS-Windows it just the way it works, in explorer and it's sort algorithms. Not sure how it is on other OS.

@TimidScript
Copy link
Author

Also apply sort order to Github import. ^_^

Zren added a commit to Zren/OpenUserJS.org that referenced this issue Aug 28, 2014
@Zren
Sort by group size (Mentioned in OpenUserJS#306). Popular groups sort…
0e6c2b7 
…By -size

Will lazily update over 2h after pushing.
Linkifies Popular Group heading. Depends on OpenUserJS#332 for CSS.
@jerone jerone mentioned this issue Aug 28, 2014
Merged
Martii added a commit that referenced this issue Sep 2, 2014
@Martii
Merge pull request #335 from Zren/groupsize
8c3fb36 
Sort by group size (Mentioned in #306). Popular groups sortBy -size
@Martii
Copy link
Member

Martii commented Jan 24, 2015

See also:

@Martii Martii added the tracking upstream Waiting, watching, wanting. label Apr 28, 2016
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue May 27, 2016
Give some visual indication on multi-level sort options
2ed34c2 
* A Userscript was incorrectly marking these for several years and missed a lot of them in the other views, so we'll mark the ones used for everyone depending on mode based on the current OUJS theme.
* Skipping `author` since there's no actual th for that

Applies a little to OpenUserJS#306, OpenUserJS#803, OpenUserJS#699, OpenUserJS#654, OpenUserJS#374 and a few others
@Martii Martii mentioned this issue May 27, 2016
Merged
@Martii
Copy link
Member

Martii commented Apr 14, 2017 •
edited
Loading

Followup from https://jira.mongodb.org/browse/SERVER-90 :

Case-insensitive indices are available in MongoDB 3.3.11 via the new collation feature.

Dev: MongoDB v3.2.11
Pro: MongoDB v3.0.12
VPS: MongoDB v2.6.11 and OpenUserJs/OpenUserJS.org/blob/47de3d8/package.json#L37 EDIT: MIGRATED and HELD to 3.4.3 on 2017 04 15 with source commented at mongo init script to squash a warning.
Latest MongoDB v3.4.3

Needs migration to a newer MongoDB data store at MongoLabs before this can be done (attempted) @sizzlemctwizzle Thanks. ... P.S. Scheduled a server backup.

@Martii Martii added DB Pertains inclusively to the Database operations. migration Use this to indicate that it may apply to an existing or announced migration. labels Apr 15, 2017
@Martii
Copy link
Member

Martii commented Apr 16, 2017 •
edited
Loading

P.S. Scheduled a server backup.

completed.

Assigned to sizzle as migration at MongoLabs is out of my hands.

Martii referenced this issue in darkred/Userscripts Feb 2, 2019
@darkred
Update OpenUserJS_Bullshit_Filter.user.js
8991f9b 
Added suggestions from https://greasyfork.org/en/forum/discussion/51981/
@Martii Martii assigned Martii and unassigned sizzlemctwizzle Feb 2, 2019
Martii added a commit to Martii/OpenUserJS.org that referenced this issue Feb 2, 2019
@Martii
Collation on find for applicable models (WIP)
a714198 
NOTES:
* Currently using level 3 for a test
* This is highly localized to `en` since that is the default language of OUJS. Needs mitigation when multiple languages are implemented. e.g. there will be languages that aren't sorted. `simple` doesn't appear to do anything useful in testing.
* May need check to ensure that whole list isn't being pulled from DB. Callback not present at these stages so guessing it isn't doing this but could be misunderstanding this. Cc: @sizzlemctwizzle @jerone @Zren *(any thoughts?)*

Applies to OpenUserJS#306
@Martii Martii mentioned this issue Feb 2, 2019
Merged
Martii added a commit to Martii/OpenUserJS.org that referenced this issue Feb 2, 2019
@Martii
Missed collation
2196c23 
Applies to OpenUserJS#306 post OpenUserJS#1578
Martii added a commit that referenced this issue Feb 2, 2019
@Martii
Collation on find for applicable models (WIP) (#1578)
dd4de48 
* Collation on `find` for applicable models (WIP)

NOTES:
* Currently using level 3 for a test
* This is highly localized to `en` since that is the default language of OUJS. Needs mitigation when multiple languages are implemented. e.g. there will be languages that aren't sorted. `simple` doesn't appear to do anything useful in testing.
* May need check to ensure that whole list isn't being pulled from DB. Callback not present at these stages so guessing it isn't doing this but could be misunderstanding this. Cc: @sizzlemctwizzle @jerone @Zren *(any thoughts?)*

Applies to #306

* Missed collation

Applies to #306 post #1578


Auto-merge ... issue still open for commenting.
@Martii
Copy link
Member

Martii commented Feb 2, 2019 •
edited
Loading

We've been able to do this for a while on the MongoDB versions even on mLab ... so applied level 3.

Ref:

Notes:

  • Needs testing to see if this is complete and as efficient as possible with the PR merged... then close. TimidScript is no longer with us as per policy.
  • Marking as a bug since I think it is after all of this time pondering and waiting.

Re:

Also apply sort order to Github import

Separate issue with dependency change/migration... leaving unaffected atm since there is no sorting period.

@Martii Martii added bug You've guessed it... this means a bug is reported. needs testing Anyone can add this but it is primarily there for the Assignee indicating that Testers are wanted. labels Feb 2, 2019
@Martii Martii removed their assignment Feb 2, 2019
@Martii Martii removed the tracking upstream Waiting, watching, wanting. label Feb 2, 2019
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Mar 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported. DB Pertains inclusively to the Database operations. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. migration Use this to indicate that it may apply to an existing or announced migration. needs testing Anyone can add this but it is primarily there for the Assignee indicating that Testers are wanted.
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sizzlemctwizzle @jerone @Martii @Zren @TimidScript