Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group Rating sort not working #374

Closed
Martii opened this issue Oct 20, 2014 · 2 comments · Fixed by #446
Closed

Group Rating sort not working #374

Martii opened this issue Oct 20, 2014 · 2 comments · Fixed by #446
Labels
bug You've guessed it... this means a bug is reported.

Comments

@Martii
Copy link
Member

Martii commented Oct 20, 2014

Tested on current dev and pro

https://openuserjs.org/groups?orderBy=rating&orderDir=desc
https://openuserjs.org/groups?orderBy=rating&orderDir=asc

No change in sort of values... not sure if sizzle is handling this with #262 but if it's just a typo somewhere that can be fixed.

Historical ref #292
@Martii Martii added the bug You've guessed it... this means a bug is reported. label Oct 20, 2014
@Martii Martii changed the title Rating sort not working Group Rating sort not working Oct 20, 2014
@Martii
Copy link
Member Author

Martii commented Oct 20, 2014

Not to mention some weird values of {} on https://openuserjs.org/groups?orderBy=rating&orderDir=desc&p=4

And how does one "Rate" a group? Automatically calculated based off of averaging the median and mean of scripts in a particular group e.g. individual scripts make this up.

@Martii Martii added the question A question has been encountered by anyone and has remained unanswered until cleared. label Oct 21, 2014
@jerone jerone self-assigned this Nov 24, 2014
@jerone jerone mentioned this issue Nov 24, 2014
Merged
Martii added a commit that referenced this issue Nov 25, 2014
@Martii
Merge pull request #446 from jerone/issue-374
2494e18 
Fix Group Rating sort not working; Fixes #374

merge
@jerone
Copy link
Contributor

jerone commented Nov 27, 2014

Confirmed fixed by #446 and also gets rid of the weird values of {}.

@Martii Martii removed the question A question has been encountered by anyone and has remained unanswered until cleared. label Jan 25, 2015
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue May 27, 2016
Give some visual indication on multi-level sort options
2ed34c2 
* A Userscript was incorrectly marking these for several years and missed a lot of them in the other views, so we'll mark the ones used for everyone depending on mode based on the current OUJS theme.
* Skipping `author` since there's no actual th for that

Applies a little to OpenUserJS#306, OpenUserJS#803, OpenUserJS#699, OpenUserJS#654, OpenUserJS#374 and a few others
@Martii Martii mentioned this issue May 27, 2016
Merged
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Group Rating sort not working; Fixes #374
2 participants
@jerone @Martii