Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libraries show Script Groups panel on .../edit route #383

Closed
Martii opened this issue Oct 21, 2014 · 4 comments · Fixed by #706
Closed

Libraries show Script Groups panel on .../edit route #383

Martii opened this issue Oct 21, 2014 · 4 comments · Fixed by #706
Labels
bug You've guessed it... this means a bug is reported.

Comments

@Martii
Copy link
Member

Martii commented Oct 21, 2014

Not sure if this is supposed to be visible or not?... but it is visible and doesn't work.

Added https://openuserjs.org/libs/Marti/GM_config to https://openuserjs.org/group/Unit_Tests yesterday and it "failed gracefully".
@Martii Martii added bug You've guessed it... this means a bug is reported. question A question has been encountered by anyone and has remained unanswered until cleared. labels Oct 21, 2014
@trespassersW
Copy link

BTW, what means Intsalls column on Libraries page?

@Martii
Copy link
Member Author

Martii commented Nov 10, 2014

#357

@Martii Martii mentioned this issue Nov 22, 2014
Merged
@Martii Martii removed the question A question has been encountered by anyone and has remained unanswered until cleared. label Aug 7, 2015
@Martii
Copy link
Member Author

Martii commented Aug 7, 2015

See conditional at 71ef808@/controllers/group.js#L65 that restricts libraries from being added to groups... removed question as this is confirmed to be a bug issue unless we want to change this behavior at some point in the future in a new issue.

@Martii Martii changed the title Libraries show Script Groups panel Libraries show Script Groups panel on .../edit route Aug 7, 2015
@Martii Martii self-assigned this Aug 7, 2015
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Aug 7, 2015
Previous code excludes libs from being added to Groups
751bbae 
* Add *mu2* conditional in to remove it from Library edit routes

Closes OpenUserJS#383
@Martii Martii mentioned this issue Aug 7, 2015
Merged
@Martii Martii removed their assignment Aug 7, 2015
@Martii
Copy link
Member Author

Martii commented Aug 7, 2015

NOTE: Leaving select2 and it's dependents in as a page global for the moment.

Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Aug 8, 2015
Remove the the rest of *select2* backbone from lib scripts
eb5f029 
* Completed some tinkering client side so removing

Applies to OpenUserJS#383
@Martii Martii mentioned this issue Aug 8, 2015
Merged
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Oct 21, 2015
Enable the missing library QSP on User home pages
45bb9be 
* User script lists by default still show both Userscripts and Libraries as designed
* The overall flow of the project has been to separate Userscripts from Libraries unless on a Users home page... putting this a little clearer will help other understand... also won't hurt our SEO rating and will help clarify when people try to upload a library script instead of Userscript.
* Groups only handle Userscripts so denote that in the tooltip
* This is breaking from USO tradition but I think it's time to give that some rest

Needed for maintaining the logic of QSP's *(some hidden)* with OpenUserJS#643 and loosely OpenUserJS#547 and post OpenUserJS#383, OpenUserJS#372, OpenUserJS#254 and probably more
@Martii Martii mentioned this issue Oct 21, 2015
Merged
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Previous code excludes libs from being added to Groups Martii/OpenUserJS.org
2 participants
@Martii @trespassersW