Enable meta cache from Server to Client #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 3, 2017 21:39
* * Caching works well but GM kills it with [`channel.LOAD_BYPASS_CACHE`](https://github.com/greasemonkey/greasemonkey/blob/696848acc40c6395904a53acdc15a653d5be502c/modules/remoteScript.js#L606) **NOTE** Keep this at one day, possibly for long term. Applies to OpenUserJS#432 and OpenUserJS#249. Possible addition to OpenUserJS#944 down the line. Regression **not** present, nor needed, from detection and revert in OpenUserJS#894 . Script meta should always be the same whether minified fork or original
Applies to OpenUserJS#432 and OpenUserJS#249. Possible addition to OpenUserJS#944 down the line.
Martii
added
CODE
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Apr 20, 2017
* Go exclusively off of HTTP/1.1 eTag and ignore `last-modified`... supported since ~1996. * HTTP/1.0 should produce 429's in this configuration NOTES: * Some of the documentation out there on the web is a bit iffy compared to actual implementation in browsers... but does match RFC'd specs. * Edge case found with oujs - Meta View ... so this is why this is happening * This transfers the load to the CPU instead of the bandwidth and is required to get things near, if not, 100% Applies to OpenUserJS#432 and post OpenUserJS#1070
Martii
added a commit
that referenced
this pull request
Apr 20, 2017
* Go exclusively off of HTTP/1.1 eTag and ignore `last-modified`... supported since ~1996. * HTTP/1.0 should produce 429's in this configuration NOTES: * Some of the documentation out there on the web is a bit iffy compared to actual implementation in browsers... but does match RFC'd specs. * Edge case found with oujs - Meta View ... so this is why this is happening * This transfers the load to the CPU instead of the bandwidth and is required to get things near, if not, 100% Applies to #432 and post #1070 Auto-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
channel.LOAD_BYPASS_CACHENOTE Keep this at one day, possibly for long term.
Applies to #432 and #249. Possible addition to #944 down the line. Regression not present, nor needed, from detection and revert in #894 . Script meta should always be the same whether minified fork or original