Enable script cache from Server to Client #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set up server to client caching for inline serving of scripts... full manual, direct method e.g. not middleware * Server to DB caching is not in this commit... additional MongoDB item will be needed for Script model to skip redoing minification constantly... will be later. During experimental phase this is probably a good thing to hold off on for a bit anyhow. * Remove minification request stdout message... already enough data on interest. Applies to OpenUserJS#432 and OpenUserJS#439
Martii
added
enhancement
Martii
added a commit
that referenced
this pull request
Feb 9, 2016
Enable script cache from Server to Client Auto-merge
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Feb 9, 2016
* See why server file caching is the way to go with *node*... will need to live with this until *UglifyJS2* harmony is released and update in *express-minify* * Minus the console message too Applies to OpenUserJS#432 and OpenUserJS#249
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Apr 4, 2017
* Caching works well but GM kills it with `channel.LOAD_BYPASS_CACHE` and TM also uses `no-cache` to retrieve initial .user.js. According to TM author libraries don't use `no-cache`. Other engines to be tested after merge. Applies to OpenUserJS#432 and OpenUserJS#249. Possible addition to OpenUserJS#944 down the line. Regression managed from detection and revert in OpenUserJS#894
Martii
added a commit
that referenced
this pull request
Apr 4, 2017
* Caching works well but GM kills it with [`channel.LOAD_BYPASS_CACHE`](https://github.com/greasemonkey/greasemonkey/blob/696848acc40c6395904a53acdc15a653d5be502c/modules/remoteScript.js#L606) and TM also uses `no-cache` to retrieve initial .user.js. According to TM author libraries *(`@require` and `@resource` inclusions)* don't use `no-cache`. Other engines to be tested after merge. Applies to #432 and #249. Possible addition to #944 down the line. Regression managed from detection and revert in #894
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Apr 4, 2017
* * Caching works well but GM kills it with [`channel.LOAD_BYPASS_CACHE`](https://github.com/greasemonkey/greasemonkey/blob/696848acc40c6395904a53acdc15a653d5be502c/modules/remoteScript.js#L606) **NOTE** Keep this at one day, possibly for long term. Applies to OpenUserJS#432 and OpenUserJS#249. Possible addition to OpenUserJS#944 down the line. Regression **not** present, nor needed, from detection and revert in OpenUserJS#894 . Script meta should always be the same whether minified fork or original
Martii
added a commit
that referenced
this pull request
Apr 4, 2017
* Enable meta cache from Server to Client * * Caching works well but GM kills it with [`channel.LOAD_BYPASS_CACHE`](https://github.com/greasemonkey/greasemonkey/blob/696848acc40c6395904a53acdc15a653d5be502c/modules/remoteScript.js#L606) **NOTE** Keep this at one day, possibly for long term. Applies to #432 and #249. Possible addition to #944 down the line. Regression **not** present, nor needed, from detection and revert in #894 . Script meta should always be the same whether minified fork or original * Scoot identifier declaration down a little Applies to #432 and #249. Possible addition to #944 down the line.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies to #432 and #249
VPS was extremely busy this morning so this needs to be addressed
And now it's saying cache is disabled on install clicks... bleh... only partially working.