Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable caching for experimental minification #1089

Merged
merged 1 commit into from
Apr 20, 2017
Merged

Reenable caching for experimental minification #1089

merged 1 commit into from
Apr 20, 2017

Conversation

Martii
Copy link
Member

@Martii Martii commented Apr 20, 2017

Applies to #432

Reenable caching for experimental minification
4a95ee1 
* Needs lastModified for this... plus bug fix on re for OpenUserJS#819

Applies to OpenUserJS#432
@Martii Martii added bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Apr 20, 2017
@Martii Martii merged commit 326d5a0 into OpenUserJS:master Apr 20, 2017
@Martii Martii deleted the Issue-432minCaching branch April 20, 2017 12:13
Martii pushed a commit to Martii/OpenUserJS.org that referenced this pull request Apr 21, 2017
Reensure a unique eTag for all script storage retrieval
a98af5c 
* Partial revert of OpenUserJS#1088 but same logic, additional logic, and with less CPU work here
* Partial revert of OpenUserJS#1089... made same logic with eTag and lastModified is no longer needed again
* Cement in the comments and de-emphasize NOTE label for these
* Change maxAge values

*NOTE*
* This makes minification live which is more accurate for debugging purposes but does use more CPU here. mtime was okay but if altering real time the *UglifyJS2* source the mtime would be incorrect.

Applies to OpenUserJS#432 and should be final mod for OpenUserJS#1079
@Martii Martii mentioned this pull request Apr 21, 2017
Merged
Martii added a commit that referenced this pull request Apr 21, 2017
@Martii
Reensure a unique eTag for all script storage retrieval (#1090)
d5cbc31 
* Partial revert of #1088 but same logic, additional logic, and with less CPU work here
* Partial revert of #1089... made same logic with eTag and lastModified is no longer needed again
* Cement in the comments and de-emphasize NOTE label for these
* Change maxAge values

*NOTE*
* This makes minification live which is more accurate for debugging purposes but does use more CPU here. mtime was okay but if altering real time the *UglifyJS2* source the mtime would be incorrect.

Applies to #432 and should be final mod for #1079

Auto-merge
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii