Reensure a unique eTag for all script storage retrieval #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Partial revert of OpenUserJS#1088 but same logic, additional logic, and with less CPU work here * Partial revert of OpenUserJS#1089... made same logic with eTag and lastModified is no longer needed again * Cement in the comments and de-emphasize NOTE label for these * Change maxAge values *NOTE* * This makes minification live which is more accurate for debugging purposes but does use more CPU here. mtime was okay but if altering real time the *UglifyJS2* source the mtime would be incorrect. Applies to OpenUserJS#432 and should be final mod for OpenUserJS#1079
Martii
added
bug
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Apr 21, 2017
Martii
added a commit
that referenced
this pull request
Apr 21, 2017
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Apr 24, 2017
* Partial revert of OpenUserJS#1091 / OpenUserJS#1090 ... should be CPU less intensive on production only but still allow live debugging of *UglifyJS2* on development where it would be needed * Some coding symmetry * Don't bother re-outputting `Last-Modified` as if it's already in the browser can be a waste of server bandwidth ... nothing found in [specs](https://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html#sec13) saying it has to be out there on a response. Applies to OpenUserJS#432 and OpenUserJS#1079
Martii
added a commit
that referenced
this pull request
Apr 24, 2017
* Partial revert of #1091 / #1090 ... should be CPU less intensive on production only but still allow live debugging of *UglifyJS2* on development where it would be needed * Some coding symmetry * Don't bother re-outputting `Last-Modified` as if it's already in the browser can be a waste of server bandwidth ... nothing found in [specs](https://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html#sec13) saying it has to be out there on a response. Applies to #432 and #1079 Auto-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE
Applies to #432 and should be final mod for #1079