Use a lookup function for meta key objects #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Begin a smaller step for existing code migration for metadata blocks... **not a full optimization round**... so please be patient. * Mimic the lookup routine from *mongoose* as well as a few more finite components of parsing from CI... return `null` instead of `undefined` like *mongoose* when not matched * Wasn't sure if it should be named `findMeta` or `queryMeta` but easily changed if wanted * Some STYLEGUIDE.md conformance * Restore original behavior of tampering with collaboration changed from OpenUserJS#686 * Add `@icon64` to uniques since existing routine only handled one. **NOTES** `findMeta` should be compatible with *pegjs* structure as I built/tested it on that branch and imported it into current HEAD and retested Applies to OpenUserJS#285
Martii
added
bug
Martii
added a commit
that referenced
this pull request
Aug 3, 2015
Use a lookup function for meta key objects Auto-merge... fully retested collaboration
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Aug 4, 2015
* Unable to find documentation on the wildcard at this time but appears that it doesn't work... closest match is an issue on *mongoose* at 3213 ... nothing I've tried works there with `{ type : Object, index : true }` or other type ... this probably isn't the final solution and another QSP would be useful to limit scope and perhaps another of exclusion of scope... but these are all encompassing searches for now.
* Those stray commas again
* Change casing on `WATCHPOINT` back to `NOTE: Watchpoint` for grep'ability
Applies to post fix OpenUserJS#696, patch for OpenUserJS#490, and solution needed in OpenUserJS#485
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nullinstead ofundefinedlike mongoose when not matchedfindMetaorqueryMetabut easily changed if wanted@icon64to uniques since existing routine only handled one.NOTES
findMetashould be compatible with pegjs structure as I built/tested it on that branch and imported it into current HEAD and retestedApplies to #285