Reestablish the model filters #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This is about the medium average point between methodologies of Zren, Jerone, SizzleMcTwizzle and myself that can managed at the moment... I tinkered with naming the QSP `filterBy`... Item, Reason, Removed By, and Date will never be filtered imho so I ended up with a merge of `byModel`. * Fixed a bug on `exports.`... * Renamed the column from `Type` to `Model` since that's probably what is going to be in here... although `strategy` model probably won't but the `orderBy` QSP is already using `model` Applies to OpenUserJS#490
Martii
added
bug
Martii
added a commit
that referenced
this pull request
Aug 5, 2015
Reestablish the model filters Auto-merge
| @@ -125,7 +125,7 @@ var parseUserSearchQuery = function (aUserListQuery, aQuery) { | |||
| fullWordMatchFields: [] | |||
| }); | |||
| }; | |||
| exports.parseCommentSearchQuery = parseCommentSearchQuery; | |||
There was a problem hiding this comment.
This is already exported once... so matched it with it's function... this is the bug mentioned.
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Aug 7, 2015
* Rename existing query filter chained condition for a DB specific use case * Create a new query filter chain specific for using defaults * Singular the search placeholder for removed items in whatever model Closes OpenUserJS#701 and post OpenUserJS#490 and OpenUserJS#700 fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filterBy... Item, Reason, Removed By, and Date will never be filtered imho so I ended up with a merge ofbyModel.exports....TypetoModelsince that's probably what is going to be in here... althoughstrategymodel probably won't but theorderByQSP is already usingmodelApplies to #490