Fix bug with User not being in removal reparse section
#908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Calling this removal reparse for lack of better naming * Fix bug on User removal when there is no other content * Fill in the basic construct for Comment and Discussion removal... designed so the top portion can be moved around to a separate function if needed... yes it might need some compression but not until the remaining switch cases are filled in to see what can code be reused. * Removal of an owned discussion "orphans" others comment however it's not fatal and keeps their comments around * When comment editing comes around... will need to call remove Comment and check if the Discussion needs to be removed as well. * Tested orphans to ensure they didn't get reassigned if a topic is resurrected. * May need a little tweaking on User Comments list with breadcrumbs but that is UI specific. * Very literal coding here... using `null` in all *async* fields... I'm aware of `undefined` but lessens the readability and contributor understanding... negligible impact * Watching for VPS timing issue with potential multiple comments... and it has been attempted on pro already by others... added a TODO for this and will watch stderr **NOTES** * Keeping OpenUserJS#126 open until all removal issues are with minimal coverage Applies to OpenUserJS#126 ... shamelessly treads on OpenUserJS#262 (comment)
Martii
added
bug
Martii
added a commit
that referenced
this pull request
Feb 26, 2016
Fix bug with `User` not being in removal reparse section Auto-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nullin all async fields... I'm aware ofundefinedbut lessens the readability and contributor understanding... negligible impactNOTES
Applies to #126 ... shamelessly treads on #262 (comment)