Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal Issue #126

Open
Martii opened this issue Jun 4, 2014 · 9 comments
Open

Removal Issue #126

Martii opened this issue Jun 4, 2014 · 9 comments
Assignees
@Martii
Labels
bug You've guessed it... this means a bug is reported. question A question has been encountered by anyone and has remained unanswered until cleared. security Usually relates to something critical.

Comments

@Martii
Copy link
Member

Martii commented Jun 4, 2014

Removed the this author from their homepage and traces seem to be still present on the site. See in the garage with this h2.comment-title.

I've manually trumped that discussion and 2 malware script comments from production but the issue still remains on account removal to the graveyard.
@Martii Martii added bug labels Jun 4, 2014
@sizzlemctwizzle
Copy link
Member

Comment editing and moderation is my next thing to tackle.

@Martii
Copy link
Member Author

Martii commented Jun 4, 2014

Btw I received my first "toobusy-js" status message... so it appears to be working.

@Martii Martii mentioned this issue Jun 10, 2014
Merged
@Martii Martii added security and removed expedite labels Jun 11, 2014
@Martii Martii added sooner and removed sooner labels Jun 22, 2014
@Martii Martii mentioned this issue Jul 12, 2014
Closed
@Martii Martii changed the title Account Removal Issue Removal Issue Jul 13, 2014
@Martii Martii added sooner and removed sooner labels Jul 13, 2014
Martii referenced this issue Jun 12, 2015
@sizzlemctwizzle
Remove discussions and comments authored by a user when that user is …
a156657 
…removed.
Martii referenced this issue Jun 12, 2015
@sizzlemctwizzle
Sync comment count when discussion page is view.
1a9933c
@Martii
Copy link
Member Author

Martii commented Jun 12, 2015

Assigned to @sizzlemctwizzle since he took this on with above commits... needs a bit additional tlc to finish this up including retesting. (hint, hint ;)

@Martii Martii added the expedite Immediate and on the front burner. label Jun 12, 2015
@Martii
Copy link
Member Author

Martii commented Jun 12, 2015

Rolled back production to last stable master HEAD of d64f754 to not block moderation as well as potential abuse with mentioned line notes on commits... resync to master on production when finished with this issue. :)

@Martii
Copy link
Member Author

Martii commented Jun 12, 2015

btw this is BLOCKING from my standpoint e.g. I won't do any merges/upvotes until resolved with either a rollback on dev source here or fixes with a close. (and retesting of course)

Do we have something similar to a findLastWhateverType(...) method in our abstracts especially for comments ? I don't seem to recall seeing one.

@sizzlemctwizzle
Copy link
Member

Sorry I was too tired last night to test my changes. Probably shouldn't have deployed my changes, but I figured I might get lucky.

@Martii
Copy link
Member Author

Martii commented Jun 12, 2015

Well besides those issues I'm thrilled that you know how to do this so easily... I started tinkering yesterday with this and failed miserably. Manually is cumbersome and I do appreciate you taking the time... just needed testing before deployment to iron out the kinks... I was quite tired too. :)

Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Jun 14, 2015
Revert changes at try for OpenUserJS#126
6bbdbbc 
* `./libs/remove.js` should do it all for this issue
* `./controllers/discussion.js` shouldn't be doing a "post" job cleanup e.g. should be done in remove.js as a "pre" job cleanup

Refs with line notes:
* OpenUserJS@a156657
* OpenUserJS@1a9933c
Martii added a commit that referenced this issue Jun 14, 2015
@Martii
Merge pull request #647 from Martii/Issue-126revert
8c39612 
Revert changes at try for #126 

Auto-merge
@Martii
Copy link
Member Author

Martii commented Jun 14, 2015

@sizzlemctwizzle
Fully reverted dev source tree here so it's not blocking... did you still want to take this or should I free it up?... usually I don't assign but it's been a few days and it would appear hung.

I'm still not ready to tinker with this more even with your additional assistance but I do have a little better understanding of how you designed it initially and how I do it manually... so might have a solution in the near future to combine the two... left some notes in the (revert) commit on my current thoughts.

@Martii Martii added the question A question has been encountered by anyone and has remained unanswered until cleared. label Jun 14, 2015
@sizzlemctwizzle
Copy link
Member

I probably won't be able to work on it for a while.
On Jun 14, 2015 3:29 AM, "Marti Martz" [email protected] wrote:

@sizzlemctwizzle https://github.com/sizzlemctwizzle
Fully reverted dev source tree here so it's not blocking... did you still
want to take this or should I free it up?... usually I don't assign but
it's been a few days and it would appear hung.

I'm still not ready to tinker with this more even with your additional
assistance but I do have a little better understanding of how you designed
it initially and how I do it manually... so might have a solution in the
near future to combine the two... left some notes in the commits on my
current thoughts.

—
Reply to this email directly or view it on GitHub
#126 (comment)
.

@Martii Martii removed the expedite Immediate and on the front burner. label Jun 15, 2015
@Martii Martii self-assigned this Feb 23, 2016
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Feb 23, 2016
Change *async* removal to be series instead of parallel
1b72e08 
* This will probably be needed for ordered and decrementing mass removals down the line... and uncovered a few logic issues
* Add some TODOs ... since this is a work in progress guestimating what should be done... final may be slightly different
* Some STYLEGUIDE.md conformance
* Add an error handler in `getFlaggedListForContent`... this will tell us if a flag has been found but no user in the non-long-term... Post OpenUserJS#643 fix in Moderation eyeball

**NOTES**
* Tested mostly on dev and some on local pro

Applies to OpenUserJS#126, OpenUserJS#93 and trounces madly upon OpenUserJS#262 (comment) ... sawwy but tiz a boog.
@Martii Martii mentioned this issue Feb 23, 2016
Merged
@Martii Martii removed their assignment Feb 23, 2016
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Feb 23, 2016
Post fix typo
f81e591 
* Show the actual model name in stderr
* Elaborated more on line notes

Applies to OpenUserJS#126 and trounces profoundly upon OpenUserJS#262 (comment)OpenUserJS#262 (comment)
@Martii Martii mentioned this issue Feb 23, 2016
Merged
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Feb 25, 2016
Add Comment and Discussion to removal
2f9a689 
* This doesn't fix the Discussion count yet but I will do that manually when needed until the TODO's are put in... saves me a query, and kill of Discussion/Comment and I'll just do a lookup of the Discussion id when needed.

Cherry picked from OpenUserJS@a156657

Applies to OpenUserJS#126
@Martii Martii mentioned this issue Feb 25, 2016
Merged
@Martii Martii self-assigned this Feb 26, 2016
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Feb 26, 2016
Fix bug with User not being in removal reparse section
9969864 
* Calling this removal reparse for lack of better naming
* Fix bug on User removal when there is no other content
* Fill in the basic construct for Comment and Discussion removal... designed so the top portion can be moved around to a separate function if needed... yes it might need some compression but not until the remaining switch cases are filled in to see what can code be reused.
* Removal of an owned discussion "orphans" others comment however it's not fatal and keeps their comments around
* When comment editing comes around... will need to call remove Comment and check if the Discussion needs to be removed as well.
* Tested orphans to ensure they didn't get reassigned if a topic is resurrected.
* May need a little tweaking on User Comments list with breadcrumbs but that is UI specific.
* Very literal coding here... using `null` in all *async* fields... I'm aware of `undefined` but lessens the readability and contributor understanding... negligible impact
* Watching for VPS timing issue with potential multiple comments... and it has been attempted on pro already by others... added a TODO for this and will watch stderr

**NOTES**
* Keeping OpenUserJS#126 open until all removal issues are with minimal coverage

Applies to OpenUserJS#126 ... shamelessly treads on OpenUserJS#262 (comment)
@Martii Martii mentioned this issue Feb 26, 2016
Merged
Martii added a commit to Martii/OpenUserJS.org that referenced this issue Oct 23, 2020
@Martii
Save role weight in flag model
e908b4e 
* When promoting/demoting a User future flagging/unflagging can wreak havoc on critical *(relative)* flags properties.
* Project bump since requires a bit of migration
* Needs followup testing with OpenUserJS#1109

Applies to OpenUserJS#126 and post OpenUserJS#641
@Martii Martii mentioned this issue Oct 23, 2020
Merged
Martii added a commit that referenced this issue Oct 23, 2020
@Martii
Save role weight in flag model (#1772)
76b018e 
* When promoting/demoting a User future flagging/unflagging can wreak havoc on critical *(relative)* flags properties.
* Project bump since requires a bit of migration
* Needs followup testing with #1109

Applies to #126 and post #641

Auto-merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Martii Martii

Labels
bug You've guessed it... this means a bug is reported. question A question has been encountered by anyone and has remained unanswered until cleared. security Usually relates to something critical.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sizzlemctwizzle @Martii