Installer disables OpenVPNService

[TitovLab]

Describe the bug
When distributing OpenVPN through Active Directory group policies, if this version has already been manually installed on the computer, the installer disables the OpenVPNService service.
This only happens if there is an exact version match. If you manually install 2.6.1, use VPN to get in touch with a domain controller, add a workstation to the domain and deploy version 2.6.2 through policies, everything will be fine.

To Reproduce

1. Install OpenVPN-2.6.2-I001-amd64.msi on a clean Windows 10 22H2
2. Add this PC to Active Directory domain
3. Deploy OpenVPN-2.6.2-I001-amd64.msi via Active Directory group policy

Expected behavior
OpenVPNService must not be set to disabled

Version information (please complete the following information):

• OS: Windows 10 19045.2728
• OpenVPN version: 2.6.2-I001-amd64

Additional context
MSI log:
MSI3174.LOG

Attracted attention two strings:

MSI (s) (6C:C8) [15:08:18:389]: Executing op: ServiceInstall(Name=OpenVPNServiceInteractive,DisplayName=OpenVPN Interactive Service,ImagePath="C:\Program Files\OpenVPN\bin\openvpnserv.exe",ServiceType=32,StartType=2,ErrorControl=1,,Dependencies=Dhcp[~][~][~],,,Password=**********,Description=Allows OpenVPN GUI and other clients to establish OpenVPN connections without administrative privileges in a secure way.,,)
MSI (s) (6C:C8) [15:08:18:389]: Executing op: ServiceInstall(Name=OpenVPNService,DisplayName=OpenVPNService,ImagePath="C:\Program Files\OpenVPN\bin\openvpnserv2.exe",ServiceType=16,StartType=4,ErrorControl=1,,Dependencies=Dhcp[~][~][~],,,Password=**********,Description=Responsible for automatic start of OpenVPN instances.,,)

Apparently the installer gives the wrong StartType for OpenVPNService. At the same time, there is no error with OpenVPNServiceInteractive, the problem is only with OpenVPNService.

[lstipakov]

This is likely due to this code:

<Custom Action="ConfigureOpenVPNService" After="StartServices">NOT Installed</Custom>

This custom action sets start mode and starts/stops the service. For new installation start mode is set to auto and service is started. For upgrade existing settings are preserved. However, this action is supposed to be run on install/upgrade.

Apparently this condition got confused by installation of the same version, and this action is not executed:

MSI (s) (6C:C8) [15:08:06:233]: Skipping action: ConfigureOpenVPNService (condition is false)

I am not too much into AD group policy but I wonder how MSI allows you to install the same version of the product?

[TitovLab]

No tuning, clean OS, clean Active Directory, a test enviroment specifically for OpenVPN.
Thoughts came to mind that this might be due to the new location of the MSI file or the update being launched under the system account - but they were not confirmed in the tests.
It is also strange that this does not happen with OpenVPNServiceInteractive - the service continues to work after such an update and it still has automatic start. The problem is only with OpenVPNService.

[lstipakov]

We set interactive service state unconditionally, and openvpn service uses custom action, which in your case is not run. I need to tune condition a bit so that it will run on install and reinstall too.