msi: configure OpenVPN Service also on reinstall #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We configure openvpn service (set startup mode and run, if needed)
only on installation or upgrade. This is achieved by running
configuration custom action with "NOT Installed" condition.
However the product may be reinstalled (even though we disable it in UI),
for example when pushed via AD Group Policy or with command line
msiexec /fomusv "OpenVPN-2.6.2-I001-amd64.msi" /L*V reinstall.log
In this case OpenVPN service status is set to "disabled", since our
configuration custom action won't be run.
Fix by changing action condition to NOT REMOVE, which covers both
install/upgrade and reinstall cases.
Fixes OpenVPN#348
Change-Id: I92974dea4749c415e25ab0f804050e3e6d309ffc
Signed-off-by: Lev Stipakov <[email protected]>
|
Also ping @selvanair |
|
LGTM. I do not understand MSI, but verified that reinstalling with |
selvanair
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We configure openvpn service (set startup mode and run, if needed) only on installation or upgrade. This is achieved by running configuration custom action with "NOT Installed" condition.
However the product may be reinstalled (even though we disable it in UI), for example when pushed via AD Group Policy or with command line
In this case OpenVPN service status is set to "disabled", since our configuration custom action won't be run.
Fix by changing action condition to NOT REMOVE, which covers both install/upgrade and reinstall cases.
Fixes #348
Change-Id: I92974dea4749c415e25ab0f804050e3e6d309ffc