test(shared-data): Fix schema 3 labware definitions not being tested #17425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We want to test that our labware definitions conform to the labware schema, that they specify sane geometry for themselves, and so on.
@caila-marashaj and I found that the labware definitions defined with schema 3 were accidentally not actually being tested. We were only running the tests on a handful of dummy test-fixture labware definitions, not our actual production (well, soon-to-be production) labware definitions. This fixes that.
Test Plan and Hands on Testing
make -C shared-data test
and inspect the output to make sure the schema 3 labware definitions are actually being tested now.Changelog
labware/definitions
, not onlylabware/fixtures
.// FIXME
comments in the code.Review requests
See the two
// FIXME
comments in the code.Risk assessment
Low.