Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(shared-data): Fix schema 3 labware definitions not being tested #17425

Merged
merged 6 commits into from
Feb 5, 2025

Conversation

SyntaxColoring
Copy link
Contributor

Overview

We want to test that our labware definitions conform to the labware schema, that they specify sane geometry for themselves, and so on.

@caila-marashaj and I found that the labware definitions defined with schema 3 were accidentally not actually being tested. We were only running the tests on a handful of dummy test-fixture labware definitions, not our actual production (well, soon-to-be production) labware definitions. This fixes that.

Test Plan and Hands on Testing

  • Run make -C shared-data test and inspect the output to make sure the schema 3 labware definitions are actually being tested now.
  • Manually break one of the schema 3 labware definitions and make sure it fails the tests.

Changelog

  • Run the tests on the labware definitions in labware/definitions, not only labware/fixtures.
  • Temporarily disable some tests that, it turns out, our labware definitions do not pass. See the two // FIXME comments in the code.

Review requests

See the two // FIXME comments in the code.

Risk assessment

Low.

@SyntaxColoring SyntaxColoring requested a review from a team as a code owner February 5, 2025 00:08
@SyntaxColoring SyntaxColoring requested review from koji and removed request for a team February 5, 2025 00:08
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.10%. Comparing base (d3e189d) to head (479d3a3).
Report is 1 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #17425       +/-   ##
===========================================
+ Coverage   18.16%   58.10%   +39.94%     
===========================================
  Files        3171     3171               
  Lines      229418   229658      +240     
  Branches     6883    16522     +9639     
===========================================
+ Hits        41665   133435    +91770     
+ Misses     187753    96034    -91719     
- Partials        0      189      +189     
Flag Coverage Δ
protocol-designer 17.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1933 files with indirect coverage changes

Resolve conflicts in shared-data/js/__tests__/labwareDefSchemaV3.test.ts.
@SyntaxColoring SyntaxColoring merged commit f9e3f04 into edge Feb 5, 2025
38 checks passed
@SyntaxColoring SyntaxColoring deleted the include_defs_in_tests branch February 5, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants