fix(shared-data): Pre-sort innerLabwareGeometry sections #17426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This addresses one of the labware definition problems identified in #17425, now that the labware definitions are actually being tested.
One of those tests makes sure that the different parts of the labware definition agree on where the tops of the wells are. The implementation of that test relies on an assumption that a well's geometry sections are defined in order from physical top to physical bottom. That assumption does not hold for most of these definitions, so the test has a lot of spurious failures, now that it's actually running.
There are two ways to resolve this:
After discussion with @caila-marashaj, we're going with option 1.
Changelog
Test Plan and Hands on Testing
checkGeometryDefinitions
test that was commented out in #17425. Make sure it has fewer failures now.// FIXME
comment incheckGeometryDefinitions
in #17425.Review requests
Glance through the labware definition changes and make sure nothing unexpected snuck into the diff.
Risk assessment
Low.