Collect username from magpie api endpoint #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeitsperre
approved these changes
Jan 16, 2024
@Zeitsperre If my memory is right, this text is in the upstream jupyterhub code. This repo is not a fork of that upstream code, it merely is a rebuild of the upstream code with added Magpie Authenticator. |
fmigneault
approved these changes
Jan 17, 2024
mishaschwartz
added a commit
to bird-house/birdhouse-deploy
that referenced
this pull request
Jan 17, 2024
## Overview Previously, JupyterHub's `MagpieAuthenticator` class treated the email address entered into the username field as the username itself. This led to a mismatch between the username in JupyterHub and the username in Magpie. To resolve this, we update the JupyterHub docker image to a version where this bug is fixed. See Ouranosinc/jupyterhub#26 and Ouranosinc/Magpie#598 for reference. ## Changes **Non-breaking changes** - Update jupyterhub to version 4.0.2-20240117 **Breaking changes** ## Related Issue / Discussion - Resolves Ouranosinc/Magpie#598 ## Additional Information Links to other issues or sources. <!-- The test suite can be run using a different DACCS config with ``birdhouse_daccs_configs_branch: branch_name`` in the PR description. To globally skip the test suite regardless of the commit message use ``birdhouse_skip_ci: true`` in the PR description. --> birdhouse_daccs_configs_branch: master birdhouse_skip_ci: false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetches the username from magpie instead of assuming that the value in the username field is a valid username (it can be an email address instead).
In response to Ouranosinc/Magpie#598