Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to log in to Jupyterhub with their email address #421

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

mishaschwartz
Copy link
Collaborator

Overview

Previously, JupyterHub's MagpieAuthenticator class treated the email address entered into the username field as the username itself. This led to a mismatch between the username in JupyterHub and the username in Magpie.

To resolve this, we update the JupyterHub docker image to a version where this bug is fixed.

See Ouranosinc/jupyterhub#26 and Ouranosinc/Magpie#598 for reference.

Changes

Non-breaking changes

  • Update jupyterhub to version 4.0.2-20240117

Breaking changes

Related Issue / Discussion

Additional Information

Links to other issues or sources.

birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false

@github-actions github-actions bot added component/jupyterhub Related to JupyterHub as development frontend with notebooks documentation Improvements or additions to documentation labels Jan 17, 2024
Copy link
Contributor

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks so much!

Copy link
Collaborator

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mishaschwartz mishaschwartz merged commit d482daf into master Jan 17, 2024
4 of 5 checks passed
@mishaschwartz mishaschwartz deleted the jupyter-magpie-login-update branch January 17, 2024 20:56
@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2419/
Result : failure

BIRDHOUSE_DEPLOY_BRANCH : jupyter-magpie-login-update
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-46.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1497/

NOTEBOOK TEST RESULTS
    
[2024-01-17T20:53:12.538Z] ============================= test session starts ==============================
[2024-01-17T20:53:12.538Z] platform linux -- Python 3.9.16, pytest-7.3.1, pluggy-1.0.0
[2024-01-17T20:53:12.538Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master
[2024-01-17T20:53:12.538Z] plugins: anyio-3.6.1, dash-2.10.0, nbval-0.9.6, tornasync-0.6.0.post2, xdist-3.3.1
[2024-01-17T20:53:12.538Z] collected 264 items
[2024-01-17T20:53:12.538Z] 
[2024-01-17T20:53:23.166Z] notebooks-auth/geoserver.ipynb ..................                        [  6%]
[2024-01-17T20:53:49.412Z] notebooks-auth/test_cowbird_jupyter.ipynb ..........                     [ 10%]
[2024-01-17T20:53:57.416Z] notebooks-auth/test_thredds.ipynb ...........                            [ 14%]
[2024-01-17T20:54:06.681Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [ 17%]
[2024-01-17T20:54:16.399Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 19%]
[2024-01-17T20:54:23.011Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb ........       [ 22%]
[2024-01-17T21:01:56.154Z] pavics-sdi-master/docs/source/notebooks/climex.ipynb ............        [ 27%]
[2024-01-17T21:01:56.154Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-climate-stations.ipynb . [ 27%]
[2024-01-17T21:01:58.140Z] ...............                                                          [ 33%]
[2024-01-17T21:02:08.067Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-xclim.ipynb .....    [ 35%]
[2024-01-17T21:02:15.057Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb ......            [ 37%]
[2024-01-17T21:02:31.573Z] pavics-sdi-master/docs/source/notebooks/forecasts.ipynb ......           [ 39%]
[2024-01-17T21:02:36.999Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 42%]
[2024-01-17T21:02:41.533Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 44%]
[2024-01-17T21:05:24.610Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 50%]
[2024-01-17T21:06:38.630Z] .............                                                            [ 54%]
[2024-01-17T21:06:40.811Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 56%]
[2024-01-17T21:06:43.024Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 59%]
[2024-01-17T21:06:59.385Z] .................                                                        [ 65%]
[2024-01-17T21:07:08.001Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb ......          [ 68%]
[2024-01-17T21:07:09.390Z] pavics-sdi-master/docs/source/notebook-components/weaver_example.ipynb . [ 68%]
[2024-01-17T21:07:27.220Z] ........F                                                                [ 71%]
[2024-01-17T21:07:37.292Z] finch-master/docs/source/notebooks/dap_subset.ipynb ...........          [ 76%]
[2024-01-17T21:07:46.783Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 78%]
[2024-01-17T21:07:48.186Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 78%]
[2024-01-17T21:07:51.292Z] ......                                                                   [ 81%]
[2024-01-17T21:07:59.439Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 81%]
[2024-01-17T21:08:13.345Z] .............                                                            [ 86%]
[2024-01-17T21:08:23.363Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 86%]
[2024-01-17T21:09:00.488Z] ....s.                                                                   [ 89%]
[2024-01-17T21:09:08.643Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 89%]
[2024-01-17T21:09:24.206Z] ...                                                                      [ 90%]
[2024-01-17T21:09:39.118Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 90%]
[2024-01-17T21:10:03.044Z] ......                                                                   [ 93%]
[2024-01-17T21:10:05.486Z] notebooks/hummingbird.ipynb ............                                 [ 97%]
[2024-01-17T21:12:45.631Z] notebooks/stress-tests.ipynb ......                                      [100%]
[2024-01-17T21:12:45.631Z] 
[2024-01-17T21:12:45.631Z] =================================== FAILURES ===================================
    
  

@tlvu
Copy link
Collaborator

tlvu commented Jan 17, 2024

@mishaschwartz you didn't run make bump patch ?

@mishaschwartz
Copy link
Collaborator Author

@tlvu Ah oops. Ok I'll fix it

mishaschwartz added a commit that referenced this pull request Jan 19, 2024
## Overview

Adds version bump that should have been added in #421 

## Changes

**Non-breaking changes**
- version bump

**Breaking changes**

## Related Issue / Discussion

## Additional Information

Links to other issues or sources.

<!--
The test suite can be run using a different DACCS config with
``birdhouse_daccs_configs_branch: branch_name`` in the PR description.
To globally skip the test suite regardless of the commit message use
``birdhouse_skip_ci: true`` in the PR description.
-->

birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/jupyterhub Related to JupyterHub as development frontend with notebooks documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [PAVICS] Logging in via email/password does not provide account name
5 participants