Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use localstorage for active events #108

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

alasdairwilson
Copy link
Collaborator

We currently use sessionStorage to store activeEventId

This changes the storing of activeeventid to localstorage, this makes the site usability a lot higher (don't have to select event on each visit or in each tab.

In my opinion session storage still makes sense for the sidebar status.

closes #87

Copy link
Contributor

@martinjrobins martinjrobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks @alasdairwilson

@martinjrobins martinjrobins merged commit 149c245 into main Nov 16, 2023
@martinjrobins martinjrobins deleted the localstorage-for-active-event branch November 16, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Course comments not visible when opened in new tab
2 participants