Compatibility Changes for PHP8 and Newer Releases of PhpUnit #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XMLReader - do not call libxml_disable_entity_loader for PHP8+
XMLWriter - 1. delete temporary files on Windows for PHP7.3+ (there had
been a problem with unlink on Windows before then).
2. Eliminate unneeded writeAttribute (tested against PhpWord
as well as Common without any issues). Current code was
a problem with newer PhpUnit.
DrawingTest - assertIsArray, when available, in lieu of assertInternalType
FileTest - assertIsString, when available, in lieu of assertInternalType
XMLReaderTest - expect exceptions in code, not DocBlock.
XMLWriterTest - 1. PHP8 ignores locale when converting float to string.
This is also a problem for PhpSpreadsheet.
2. Added some tests to improve coverage.