Compatibility with PHP 8.0 #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liborm85
commented
Oct 18, 2020
•
liborm85
commented
- compatibility with PHP 8.0 (for full support require update in 3rd libraries)
- fixed travis tests for PHP 5.3, 5.4, 5.5 and 7.1+
liborm85
force-pushed
the
php80
branch
2 times, most recently
from
2cebe42 to
c05bc8d
Compare
liborm85
force-pushed
the
php80
branch
4 times, most recently
from
175f160 to
155d7a9
Compare
This assert is irelevant for test.
liborm85
force-pushed
the
php80
branch
2 times, most recently
from
d66e4b3 to
885d1a1
Compare
|
@Progi1984 Can you review it? |
3 tasks
3 tasks
|
@liborm85 Fixed in |
|
@Progi1984 In develop branch is not fixed Fortunately PHPWord no longer uses Common package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.