Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for Indentation & Tabs on RTF Writer. #1405

Merged
merged 28 commits into from
Jul 14, 2018

Conversation

smaug1985
Copy link
Contributor

@smaug1985 smaug1985 commented Jun 5, 2018

Description

I added support for indentation and Tabs when sing RTF writer.

Fixes # (issue)

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have update the documentation to describe the changes

@troosan
Copy link
Contributor

troosan commented Jul 9, 2018

@smaug1985 would you mind fixing the issues raised by php-cs and scrutinizer?

@troosan
Copy link
Contributor

troosan commented Jul 9, 2018

@smaug1985 you can run the checks locally with composer run-script check --timeout=0

@smaug1985
Copy link
Contributor Author

Thank you, but actually I dont have a working dev environment. I'm working in a simple way. I fixed all the syntaxs issues. But I don't know how to fix the last error. Can you help me, please?

@coveralls
Copy link

coveralls commented Jul 10, 2018

Coverage Status

Coverage decreased (-0.05%) to 94.854% when pulling 390d543 on smaug1985:develop into 4fa9455 on PHPOffice:develop.

@troosan troosan added this to the v0.15.0 milestone Jul 13, 2018
troosan added 3 commits July 14, 2018 01:11
rtf_indent_tabs_writer

Conflicts:
	src/PhpWord/Writer/RTF/Style/Tab.php
@troosan troosan merged commit 3906be1 into PHPOffice:develop Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants