Update requirement to PHP 7.2 #1951

stephanvierkant · 2020-10-21T19:45:24Z

Description

I've updated the required PHP to 7.2 Please note that this version is already out of active support: https://www.php.net/supported-versions.php. It has security support until 30 Nov 2020.

I've used Rector to do some small updates to the codebase. I haven't added any typing (type hints, return types) yet.

Checklist:

I have run composer run-script check --timeout=0 and no errors were reported
The new code is covered by unit tests (check build/coverage for coverage report)
I have updated the documentation to describe the changes

Should be merged after #1946.
Fixes #1948.

liborm85 · 2020-10-25T08:33:59Z

src/PhpWord/Element/Section.php

@@ -217,7 +217,7 @@ private function addHeaderFooter($type = Header::AUTO, $header = true)
        $collection = &$this->$collectionArray;

        if (in_array($type, array(Header::AUTO, Header::FIRST, Header::EVEN))) {
-            $index = count($collection);
+            $index = is_countable($collection) ? count($collection) : 0;


Why is_countable check? Properties $this->headers and $this->footers is array.

liborm85 · 2020-10-25T08:35:13Z

src/PhpWord/Style/ListItem.php

@@ -263,7 +263,7 @@ private function getListTypeStyle()

        // Populate style and register to global Style register
        $style = $listTypeStyles[$this->listType];
-        $numProperties = count($properties);
+        $numProperties = is_countable($properties) ? count($properties) : 0;


Why is_countable check? Variable $properties is array.

liborm85 · 2020-10-25T08:36:48Z

README.md

@@ -60,7 +60,7 @@ With PHPWord, you can create OOXML, ODF, or RTF documents dynamically using your

 PHPWord requires the following:

- PHP 5.3.3+
+- A [supported version of PHP](https://www.php.net/supported-versions.php) 


It's ambiguous. I would rather give a specific version number as before - PHP 7.2+

liborm85 · 2020-10-25T08:42:30Z

composer.json

        "dompdf/dompdf":"0.8.*",
        "tecnickcom/tcpdf": "6.*",
-        "mpdf/mpdf": "5.7.4 || 6.* || 7.*",
+        "mpdf/mpdf": "7.* || 8.*",
+        "rector/rector": "^0.8",


You only used rector library for conversion. Now, in my opinion, not needed as require-dev, including the following rector.php file. Remove it.

In think this could be useful to add other rules as well. See Rector as a phpcsfixer-like tool.

Thanks for the feedback, I'll work on it as soon as your PR has been merged.

liborm85 · 2020-10-25T08:45:27Z

src/PhpWord/Shared/OLERead.php

@@ -262,6 +262,7 @@ private function readPropertySets()
            $name = str_replace("\x00", "", substr($data, 0, $nameSize));


+            $this->props = (array) $this->props;


Why this cast? The problem is in the missing definition of variable for class. Just add private $props = [];.

liborm85 · 2020-10-25T08:48:05Z

src/PhpWord/Writer/Word2007.php

@@ -175,7 +175,7 @@ private function addHeaderFooterMedia(ZipArchive $zip, $docPart)
        $elements = Media::getElements($docPart);
        if (!empty($elements)) {
            foreach ($elements as $file => $media) {
-                if (count($media) > 0) {
+                if ((is_countable($media) ? count($media) : 0) > 0) {


Same as above, variable $media is array.

liborm85 · 2020-10-25T08:58:46Z

src/PhpWord/Settings.php


    /**
     * PDF rendering libraries
     *
     * @const string
     */
    const PDF_RENDERER_DOMPDF = 'DomPDF';
-    const PDF_RENDERER_TCPDF = 'TCPDF';
+    const PDF_RENDERER_TCPDF = \TCPDF::class;


This contant is not a class designation. Class \TCPDF may not exist.

liborm85 · 2020-10-25T09:03:32Z

src/PhpWord/Settings.php

-    const ZIPARCHIVE = 'ZipArchive';
-    const PCLZIP = 'PclZip';
-    const OLD_LIB = 'PhpOffice\\PhpWord\\Shared\\ZipArchive'; // @deprecated 0.11
+    const ZIPARCHIVE = \ZipArchive::class;


Class \ZipArchive is part of ext-zip extension. In production install PHPWord does not require ext-zip. Class \ZipArchive may not exist.

liborm85 · 2020-10-25T09:05:43Z

rector.php

@@ -0,0 +1,22 @@
+<?php


Remove file, explained above.

stephanvierkant added 4 commits October 21, 2020 21:35

Update requirement to PHP 7.2 and used Rector for some basic changes.

f4f3988

Updated php_codesniffer because of deprecation notices

d068664

updated readme

37a5088

Updated travis configuration

5fdf567

stephanvierkant marked this pull request as draft October 22, 2020 11:44

liborm85 suggested changes Oct 25, 2020

View reviewed changes

stephanvierkant closed this Feb 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update requirement to PHP 7.2 #1951

Update requirement to PHP 7.2 #1951

stephanvierkant commented Oct 21, 2020 •

edited

Loading

liborm85 Oct 25, 2020

liborm85 Oct 25, 2020

liborm85 Oct 25, 2020

liborm85 Oct 25, 2020

stephanvierkant Oct 26, 2020

liborm85 Oct 25, 2020

liborm85 Oct 25, 2020

liborm85 Oct 25, 2020

liborm85 Oct 25, 2020

liborm85 Oct 25, 2020

		@@ -262,6 +262,7 @@ private function readPropertySets()
		$name = str_replace("\x00", "", substr($data, 0, $nameSize));


		$this->props = (array) $this->props;

Update requirement to PHP 7.2 #1951

Update requirement to PHP 7.2 #1951

Conversation

stephanvierkant commented Oct 21, 2020 • edited Loading

Description

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stephanvierkant commented Oct 21, 2020 •

edited

Loading