Compatibility with PHP 7.4, PHP 8.0 and migrate to Laminas Escaper #1946

liborm85 · 2020-10-17T09:34:58Z

Description

compatibility with PHP 7.4
compatibility with PHP 8.0 (for full support require update in 3rd libraries)
travis-ci: fixed execution on PHP 5.x
fixed scrutinizer, allow zip extension
migrate from abandoned Zend\Escaper to Laminas Escaper

For full compatibility with php 8.0 require PR PHPOffice/Common#34

Fixes #1944
Fixes #1874
Fixes #1797

Checklist:

I have run composer run-script check --timeout=0 and no errors were reported
The new code is covered by unit tests (check build/coverage for coverage report)
I have updated the documentation to describe the changes

avoid notice: "Invalid characters passed for attempted conversion, these have been ignored"

- in PHP 7.3, 7.4 not necessary remove ignore platforms

…ault

… not contain any null bytes

version 6.3.5 doesn't support PHP 5.3, fixed via tecnickcom/TCPDF#197, pending new release.

…e argument list"

stephanvierkant · 2020-10-19T12:25:49Z

src/PhpWord/Element/Image.php

@@ -454,7 +454,7 @@ private function setSourceType()
            } else {
                $this->sourceType = self::SOURCE_GD;
            }
-        } elseif (@file_exists($this->source)) {
+        } elseif ((strpos($this->source, chr(0)) === false) && @file_exists($this->source)) {


We could use PHP8-functions here, with a polyfill from Symfony.

I don't see any new feature in php8 or symfony polyfills to solve this problem.

str_contains

https://github.com/symfony/polyfill/blob/master/src/Php80/Php80.php#L91

str_contains doesn't solve much... Symfony polyfills require PHP 7, not compatible with PHP 5.x https://github.com/symfony/polyfill/blob/master/src/Php80/composer.json#L23

Is that a serious problem? We should drop support for PHP 5 ASAP: #1948

And no, it ‘str_contains‘ doesn't solve a problem, but I think it's nicer. It improves readability for example.

Yes, this is problem, because this PR is about compatibility with PHP 8 and PHP 7.4, not about drop support old PHP versions.

That's true. I opened an issue, I'd like to hear your opinion :)

liborm85 · 2020-10-20T05:23:52Z

@troosan Can you review it?

michaljusiega · 2020-11-20T10:03:48Z

Let's release this changes please ;)

dsuurlant · 2020-12-07T13:52:30Z

Looking forward to this PR being merged! Is there anything I could do to contribute?

stephanvierkant · 2020-12-07T18:18:15Z

@troosan doesn't seem to be active here. How can we contact him? Are there any other maintainers?

troosan · 2020-12-29T21:47:18Z

@stephanvierkant Thanks for this nice work. I've been quite absent for quite some time indeed.
I'll take some time to merge what can be merged and release a new version.

stephanvierkant · 2020-12-30T07:42:43Z

Hi @troosan, welcome back! And you're welcome, but credits to @liborm85 for this PR.

troosan · 2021-02-06T21:43:24Z

indeed, will definitely mention it in the release notes

…/laminas-zendframework-bridge This commit fixes the BC break introduced by PHPOffice#1946 where it was stated that phpword replaces package laminas/laminas-zendframework-bridge which is not the case. Package laminas/laminas-zendframework-bridge only was replaced from phpword.

Fix BC break in #1946. This package does not replace laminas/laminas-zendframework-bridge

liborm85 added 17 commits October 17, 2020 12:56

allow PHP 7.4, 8.0

adb9172

compatibility with phpmd 2.9

e334ecf

PHP 7.4 - fixed invalid value in hexdec

9dad1d2

avoid notice: "Invalid characters passed for attempted conversion, these have been ignored"

- composer in php 5.x require increase memory limit

7fd4b64

- in PHP 7.3, 7.4 not necessary remove ignore platforms

PHP 8.0 - depracated libxml_disable_entity_loader, is disabled by def…

9397821

…ault

PHP 8.0 fix - ValueError: file_exists(): Argument #1 ($filename) must…

9c6cf6f

… not contain any null bytes

forgotten condition for libxml_disable_entity_loader

93579e9

rewrite check to local file

a36a429

PHP 8.0 - fixed Error: Unknown named parameter $styles

bf1bb2b

revert from develop branch

2845284

fix code format

236c7c4

allow php 5.3, 5.4, 5.5 except xenial os

0edcab0

fix format for coverage

eaf2212

skip TCPDF test in PHP 5.3, because

6d49b28

version 6.3.5 doesn't support PHP 5.3, fixed via tecnickcom/TCPDF#197, pending new release.

scrutinizer fix, allow zip extension

b7dc71a

fix cs issue: "Arguments with default values must be at the end of th…

b8ffe04

…e argument list"

refixed "must not contain any null bytes"

4e4282a

liborm85 changed the title ~~[WIP] PHP 8.0 in Travis~~ [WIP] Compatibility with PHP 7.4 and PHP 8.0 Oct 18, 2020

migrate from abandoned Zend\Escaper to Laminas Escaper

f2516b0

liborm85 changed the title ~~[WIP] Compatibility with PHP 7.4 and PHP 8.0~~ [WIP] Compatibility with PHP 7.4, PHP 8.0 and migrate to Laminas Escaper Oct 18, 2020

liborm85 changed the title ~~[WIP] Compatibility with PHP 7.4, PHP 8.0 and migrate to Laminas Escaper~~ [WIP] Compatibility with PHP 7.4, PHP 8.0 and migrate to Laminas Escaper Oct 18, 2020

liborm85 mentioned this pull request Oct 18, 2020

Update composer.json #1916

Closed

travis upgrade to PHPUnit 8 for PHP 8

4cc2cc1

stephanvierkant reviewed Oct 19, 2020

View reviewed changes

travis php 8 - convert tests from phpunit 7 format to phpunit 8 format

6b99923

liborm85 changed the title ~~[WIP] Compatibility with PHP 7.4, PHP 8.0 and migrate to Laminas Escaper~~ Compatibility with PHP 7.4, PHP 8.0 and migrate to Laminas Escaper Oct 20, 2020

liborm85 marked this pull request as ready for review October 20, 2020 05:23

liborm85 mentioned this pull request Oct 20, 2020

Package zendframework/zend-escaper is abandoned, you should avoid using it. Use laminas/laminas-escaper instead. #1944

Closed

stephanvierkant mentioned this pull request Oct 22, 2020

Update requirement to PHP 7.2 #1951

Closed

3 tasks

caugner mentioned this pull request Nov 24, 2020

Replace abandoned zend-escaper by laminas-escaper #1973

Closed

3 tasks

liborm85 mentioned this pull request Nov 27, 2020

php 8 #1975

Closed

3 tasks

liborm85 mentioned this pull request Dec 8, 2020

PHP 8 #1979

Closed

liborm85 added 3 commits December 9, 2020 13:03

travis support latest php as 8.0 now

a9e0125

update ugly hack for PHPUnit 8 support

4b4dfb4

skip test, because php 8.0 contain internally validation

36b63a1

stephanvierkant mentioned this pull request Dec 22, 2020

PHPWord maintainers PHPOffice/PhpSpreadsheet#1765

Closed

troosan added this to the v0.18.0 milestone Dec 29, 2020

troosan merged commit 7a97d24 into PHPOffice:develop Dec 29, 2020

liborm85 deleted the php80 branch January 1, 2021 14:51

This was referenced Feb 7, 2021

move from "zendframework/zend-escaper" to "laminas/laminas-escaper" #1795

Closed

Patch 1 #1798

Closed

mussbach mentioned this pull request Feb 26, 2021

Replacing laminas/laminas-zendframework-bridge without providing its functionality breaks packages #2028

Closed

mussbach mentioned this pull request Mar 4, 2021

Fix BC break in #1946. This package does not replace laminas/laminas-zendframework-bridge #2032

Merged

3 tasks

PowerKiKi added a commit that referenced this pull request Mar 8, 2021

Merge pull request #2032 from mussbach/f_2028_dont_replace_package

84d1da6

Fix BC break in #1946. This package does not replace laminas/laminas-zendframework-bridge

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compatibility with PHP 7.4, PHP 8.0 and migrate to Laminas Escaper #1946

Compatibility with PHP 7.4, PHP 8.0 and migrate to Laminas Escaper #1946

liborm85 commented Oct 17, 2020 •

edited

Loading

stephanvierkant Oct 19, 2020

liborm85 Oct 19, 2020

stephanvierkant Oct 19, 2020

liborm85 Oct 19, 2020

stephanvierkant Oct 19, 2020 •

edited

Loading

liborm85 Oct 20, 2020

stephanvierkant Oct 20, 2020

liborm85 commented Oct 20, 2020

michaljusiega commented Nov 20, 2020

dsuurlant commented Dec 7, 2020

stephanvierkant commented Dec 7, 2020

troosan commented Dec 29, 2020

stephanvierkant commented Dec 30, 2020

troosan commented Feb 6, 2021

Compatibility with PHP 7.4, PHP 8.0 and migrate to Laminas Escaper #1946

Compatibility with PHP 7.4, PHP 8.0 and migrate to Laminas Escaper #1946

Conversation

liborm85 commented Oct 17, 2020 • edited Loading

Description

Checklist:

stephanvierkant Oct 19, 2020

Choose a reason for hiding this comment

liborm85 Oct 19, 2020

Choose a reason for hiding this comment

stephanvierkant Oct 19, 2020

Choose a reason for hiding this comment

liborm85 Oct 19, 2020

Choose a reason for hiding this comment

stephanvierkant Oct 19, 2020 • edited Loading

Choose a reason for hiding this comment

liborm85 Oct 20, 2020

Choose a reason for hiding this comment

stephanvierkant Oct 20, 2020

Choose a reason for hiding this comment

liborm85 commented Oct 20, 2020

michaljusiega commented Nov 20, 2020

dsuurlant commented Dec 7, 2020

stephanvierkant commented Dec 7, 2020

troosan commented Dec 29, 2020

stephanvierkant commented Dec 30, 2020

troosan commented Feb 6, 2021

liborm85 commented Oct 17, 2020 •

edited

Loading

stephanvierkant Oct 19, 2020 •

edited

Loading