ekf2: reduce GPS initialization time for SITL from 10s to 0.5s #12021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What was the reason it took longer earlier? Do we understand the implications. I would like a reduction to 3 seconds but I wouldn't ask for 0.5 seconds. If EKF2 takes a while it should be reflected in SITL as well. You can always speed up SITL using |
|
I'd rather expose this as a parameter than have board specific defines in modules. That would also allow it to be used for HITL. |
Speeds up SITL startup.
bkueng
force-pushed
the
sitl_gps_fast_init
branch
from
c2e52d5 to
d3d7f6b
Compare
|
@julianoes this is a usability issue: the faster we get SITL to start, the more people have time to test, and the better the experience, so they are also likely to test more. PX4_SIM_SPEED_FACTOR does not help for flight control testing. @dagar I wanted to avoid adding another parameter, but alright. |
LorenzMeier
approved these changes
May 28, 2019
bkueng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds up SITL startup (from PX4/PX4-ECL#603).
The ecl submodule update also includes PX4/PX4-ECL#597, which is why this PR is marked as WIP and not meant to be merged before the release.
@RomanBapst fyi.