Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins enable rover SITL test #12117

Merged
merged 3 commits into from
Jun 15, 2019
Merged

Jenkins enable rover SITL test #12117

merged 3 commits into from
Jun 15, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented May 30, 2019

Describe problem solved by the proposed pull request
There are no existing SITL tests for the rover.

Describe your preferred solution
A rover mission, rover_mission_1, was added to Jenkins. It is a simple mission consisting of driving to 3 waypoints.

@AmeliaEScott
Copy link
Contributor

I am currently trying to get this to work, but it will depend upon this PR in the sitl_gazebo repo: PX4/PX4-SITL_gazebo-classic#329

@AmeliaEScott AmeliaEScott force-pushed the pr-jenkins_sitl_rover branch 3 times, most recently from 24d6e45 to 77c9aef Compare June 14, 2019 09:20
@AmeliaEScott AmeliaEScott force-pushed the pr-jenkins_sitl_rover branch from 77c9aef to f365ccc Compare June 14, 2019 09:54
@AmeliaEScott AmeliaEScott marked this pull request as ready for review June 14, 2019 09:54
@AmeliaEScott AmeliaEScott changed the title WIP: Jenkins enable rover SITL test Jenkins enable rover SITL test Jun 14, 2019
@AmeliaEScott AmeliaEScott requested a review from julianoes June 14, 2019 09:55
@@ -61,6 +61,13 @@ pipeline {
vehicle: "iris"
],

[
name: "Rover 1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dagar what was your thought behind "Rover 1"? Is there going to be another one? 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wishful thinking that we were going to have significantly more of these tests.

@dagar
Copy link
Member Author

dagar commented Jun 15, 2019

Thanks for finishing this @ItsTimmy.

@dagar dagar merged commit a175c44 into master Jun 15, 2019
@dagar dagar deleted the pr-jenkins_sitl_rover branch June 15, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants