Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Safe Landing Planner to CI #12266

Merged
merged 3 commits into from
Aug 2, 2019
Merged

Add Safe Landing Planner to CI #12266

merged 3 commits into from
Aug 2, 2019

Conversation

mrivi
Copy link
Contributor

@mrivi mrivi commented Jun 14, 2019 •
edited
Loading

  • update avoidance ci to release 0.3.0
  • add safe landing planner CI

@mrivi mrivi force-pushed the slp_ci branch 3 times, most recently from e398503 to 8979abf Compare June 14, 2019 11:20
@weekly-digest weekly-digest bot mentioned this pull request Jun 16, 2019
Closed
@mrivi mrivi force-pushed the slp_ci branch 2 times, most recently from e2cfd96 to 285a9d5 Compare June 25, 2019 14:11
@mrivi
Copy link
Contributor Author

mrivi commented Jun 25, 2019

@dagar we are seeing this issue #11662 in the CI with the updated containers. Downgrading PyYAML from 5.1 to 3.13 could be an option

@dagar
Copy link
Member

dagar commented Jun 25, 2019

@dagar we are seeing this issue #11662 in the CI with the updated containers. Downgrading PyYAML from 5.1 to 3.13 could be an option

We can pin it to a known working version.
https://github.com/PX4/Firmware/blob/46662072d162011178655b026dae140d8a5c0836/Tools/setup/requirements.txt#L11

@mrivi mrivi force-pushed the slp_ci branch 6 times, most recently from 0ae6253 to d81796b Compare June 26, 2019 09:29
@mrivi
Copy link
Contributor Author

mrivi commented Jun 26, 2019

@dagar we would need to downgrade PyYaml on the container side, right?
@TSC21 - What do you think about fixing the issue on the mavros side instead?

@TSC21
Copy link
Member

TSC21 commented Jun 26, 2019

@TSC21 - What do you think about fixing the issue on the mavros side instead?

Related: mavlink/mavros#1210. I guess either way is fine - it's not a matter of a fix since this worked before with pyyaml. So I guess since we are moving the pyyaml version further we can add the workaround on the px4_config.yaml for now.

@mrivi mrivi force-pushed the slp_ci branch 4 times, most recently from 2ffbdc6 to af43682 Compare June 26, 2019 13:53
@weekly-digest weekly-digest bot mentioned this pull request Jun 30, 2019
Closed
@mrivi mrivi marked this pull request as ready for review August 2, 2019 11:52
@mrivi
Copy link
Contributor Author

mrivi commented Aug 2, 2019

@dagar could we get this in?

@dagar dagar merged commit 959a35b into master Aug 2, 2019
@dagar dagar deleted the slp_ci branch August 2, 2019 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagar dagar dagar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrivi @dagar @TSC21