-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create a range of common quadcopter frame sizes and general ROMFS cleanup #9849
Conversation
If there's concern over general churn or some of the airframes that have been added or removed I propose we set up a quick call to review this. |
TODO
|
FWIW I think this is a hell of a lot better end user story - I would know what to select now (either a specific vehicle because that is RTF with no configuration, or a generic config for my frame size). When this is in we should review the docs in QGC and PX4 user guide to make it clear how you make the selection. |
This looks good except for the various SYS_AUTOSTART ID changes. I understand the intent but it unnecessarily breaks a lot of existing setups. E.g: EDIT:
|
Suggestion from @MaEtUgR on the dev call to limit the generic quadcopter selection to small, medium, large. |
That is probably a good idea, but is there a good shared understanding of what those sizes mean, and if not, how would it be conveyed? |
Example of how we're hurting users. #10099 For a non-technical user getting out of this state is quite difficult. |
Happy to review & help to get in if you rebase. In terms of "bricking": We need support in the bootloader to trigger a complete system reset. |
@dagar, I've deconflicted your work here: https://github.com/mcsauder/Firmware/tree/pr-airframe_cleanup EDIT: The current compare isn't too bad: master...mcsauder:pr-airframe_cleanup |
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
43c77bd
to
60c13ec
Compare
60c13ec
to
43c77bd
Compare
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
Closing as stale. |
This was motivated by px4fmu-v2 flash space, but it's something I've wanted to improve for some time now.
One common source of confusion I see with new (and even experienced) users is not knowing where to start with airframe selection. We have a range of issues with the default airframes, including fairly generic configurations that are named specifically, or configurations that target a common frame that include many details specific to one particular users setup. The vast majority will never have the exact same setup, and users often end up playing a guessing game.
This PR attempts to start addressing some of these issues.