Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a range of common quadcopter frame sizes and general ROMFS cleanup #9849

Closed
wants to merge 10 commits into from

Conversation

dagar
Copy link
Member

@dagar dagar commented Jul 6, 2018

This was motivated by px4fmu-v2 flash space, but it's something I've wanted to improve for some time now.

One common source of confusion I see with new (and even experienced) users is not knowing where to start with airframe selection. We have a range of issues with the default airframes, including fairly generic configurations that are named specifically, or configurations that target a common frame that include many details specific to one particular users setup. The vast majority will never have the exact same setup, and users often end up playing a guessing game.

This PR attempts to start addressing some of these issues.

  • create a range of airframes for common quadcopter frame sizes
  • don't configure parameters that don't correspond to the actual airframe
    • an airframe for a frame kit shouldn't include PWM settings for particular ESCs unless they come with the kit
    • an airframe shouldn't include user preferences for things like frsky_telemetry
  • delete unnecessary airframes for things like vmount or CAN usage. These can easily be configured with a param change.

@dagar
Copy link
Member Author

dagar commented Jul 6, 2018

If there's concern over general churn or some of the airframes that have been added or removed I propose we set up a quick call to review this.

@dagar
Copy link
Member Author

dagar commented Jul 6, 2018

Here's what QGC airframe selection looks like with this PR.

screenshot from 2018-07-06 11-43-56

Compared to current master.
screenshot from 2018-07-06 11-45-22

@dagar
Copy link
Member Author

dagar commented Jul 6, 2018

TODO

  • review and consolidate
    • all VTOLs
    • Quadrotor Wide category
    • helicopters and coaxial helicopters (there should be generics)
    • flying wings (these could all be using the same mixer)
  • review generic options in all categories

@hamishwillee
Copy link
Contributor

hamishwillee commented Jul 8, 2018

FWIW I think this is a hell of a lot better end user story - I would know what to select now (either a specific vehicle because that is RTF with no configuration, or a generic config for my frame size).

When this is in we should review the docs in QGC and PX4 user guide to make it clear how you make the selection.

@bkueng
Copy link
Member

bkueng commented Jul 11, 2018

This looks good except for the various SYS_AUTOSTART ID changes. I understand the intent but it unnecessarily breaks a lot of existing setups. E.g:
4010 -> 4330
4011 -> 4450
4050 -> 4251
1001 -> 4002

EDIT:
We could add transition logic in the form:

if param compare SYS_AUTOSTART 4010
then
  param set SYS_AUTOSTART 4330
fi

@dagar
Copy link
Member Author

dagar commented Jul 11, 2018

Suggestion from @MaEtUgR on the dev call to limit the generic quadcopter selection to small, medium, large.

@hamishwillee
Copy link
Contributor

Suggestion from @MaEtUgR on the dev call to limit the generic quadcopter selection to small, medium, large.

That is probably a good idea, but is there a good shared understanding of what those sizes mean, and if not, how would it be conveyed?

@dagar
Copy link
Member Author

dagar commented Aug 1, 2018

Example of how we're hurting users. #10099

For a non-technical user getting out of this state is quite difficult.

@LorenzMeier
Copy link
Member

Happy to review & help to get in if you rebase.

In terms of "bricking": We need support in the bootloader to trigger a complete system reset.

@stale stale bot closed this Feb 4, 2019
@dagar dagar reopened this Feb 6, 2019
@PX4 PX4 deleted a comment from stale bot Feb 6, 2019
@PX4 PX4 deleted a comment from stale bot Feb 6, 2019
@mcsauder
Copy link
Contributor

mcsauder commented Jun 12, 2019

@dagar, I've deconflicted your work here: https://github.com/mcsauder/Firmware/tree/pr-airframe_cleanup

EDIT: The current compare isn't too bad: master...mcsauder:pr-airframe_cleanup

@stale
Copy link

stale bot commented Oct 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale
Copy link

stale bot commented Apr 27, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale
Copy link

stale bot commented Aug 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Aug 16, 2020
@LorenzMeier
Copy link
Member

Closing as stale.

@LorenzMeier LorenzMeier deleted the pr-airframe_cleanup branch January 18, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants