Add generic vtol tailsitter airframe and modifiy 4001_quad_x and 13001_caipirinha_vtol to simplify PR 9849 #12506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsauder
force-pushed
the
airframe_cleanup_1
branch
from
bc6b40e to
15f8209
Compare
mcsauder
force-pushed
the
airframe_cleanup_1
branch
2 times, most recently
from
2fc5ce4 to
029db09
Compare
mcsauder
force-pushed
the
airframe_cleanup_1
branch
3 times, most recently
from
3e57f5b to
b8a3aa4
Compare
mcsauder
force-pushed
the
airframe_cleanup_1
branch
from
b8a3aa4 to
527e9ce
Compare
|
@RomanBapst, I rebased on current master, let me know if you need anything from me on this PR. Thanks! |
mcsauder
force-pushed
the
airframe_cleanup_1
branch
from
527e9ce to
082a004
Compare
mcsauder
force-pushed
the
airframe_cleanup_1
branch
from
082a004 to
48b1dd0
Compare
|
@RomanBapst and @dagar , rebased against current master. Do you need anything else from me on this PR? |
RomanBapst
previously approved these changes
Aug 18, 2019
|
Thanks for your review @RomanBapst! |
|
Hi @dagar and @RomanBapst , anything else you'd like to see in this PR from me? |
…ons from PR 9849 in 4001_quad_x and 13001_caipirinha_vtol.
mcsauder
force-pushed
the
airframe_cleanup_1
branch
from
48b1dd0 to
b26e7cc
Compare
|
Rebased on current master to see if we can make CI happy again. |
dagar
approved these changes
Sep 1, 2019
|
Thanks @dagar ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by the proposed pull request
This PR is designed to advance PR #9849. A generic VTOL tailsitter airframe and mixer is added and the modifications to 4001_quad_x and 13001_caipirinha_vtol from PR #9849 are made here.
Additional context
This PR is a step toward accomplishing the work in #9489 in a piecewise process. The full diff for the completed work can be seen here.
Please let me know if you have any questions on this PR! Thanks!
-Mark