Make all array constructors explicit (#99)

* Make all array constructors explicit

to avoid accidental implicit casts like e.g.
Vector3f v = 0;
assigning nullpointer content.

matrix/AxisAngle.hpp

@@ -37,7 +37,7 @@ class AxisAngle : public Vector<Type, 3>
      *
      * @param data_ array
      */
-    AxisAngle(const Type data_[3]) :
+    explicit AxisAngle(const Type data_[3]) :
         Vector<Type, 3>(data_)
     {
     }

matrix/Dcm.hpp

@@ -56,7 +56,16 @@ class Dcm : public SquareMatrix<Type, 3>
      *
      * @param _data pointer to array
      */
-    Dcm(const Type *data_) : SquareMatrix<Type, 3>(data_)
+    explicit Dcm(const Type data_[3][3]) : SquareMatrix<Type, 3>(data_)
+    {
+    }
+
+    /**
+     * Constructor from array
+     *
+     * @param _data pointer to array
+     */
+    explicit Dcm(const Type data_[3*3]) : SquareMatrix<Type, 3>(data_)
     {
     }
 

matrix/Matrix.hpp

@@ -41,12 +41,12 @@ class Matrix
     // Constructors
     Matrix() = default;
 
-    Matrix(const Type data_[M*N])
+    explicit Matrix(const Type data_[M*N])
     {
         memcpy(_data, data_, sizeof(_data));
     }
 
-    Matrix(const Type data_[M][N])
+    explicit Matrix(const Type data_[M][N])
     {
         memcpy(_data, data_, sizeof(_data));
     }

matrix/Quaternion.hpp

@@ -61,7 +61,7 @@ class Quaternion : public Vector<Type, 4>
      *
      * @param data_ array
      */
-    Quaternion(const Type data_[4]) :
+    explicit Quaternion(const Type data_[4]) :
         Vector<Type, 4>(data_)
     {
     }

matrix/SquareMatrix.hpp

@@ -28,7 +28,12 @@ class SquareMatrix : public Matrix<Type, M, M>
 public:
     SquareMatrix() = default;
 
-    SquareMatrix(const Type data_[M][M]) :
+    explicit SquareMatrix(const Type data_[M][M]) :
+        Matrix<Type, M, M>(data_)
+    {
+    }
+
+    explicit SquareMatrix(const Type data_[M*M]) :
         Matrix<Type, M, M>(data_)
     {
     }

matrix/Vector.hpp

@@ -29,7 +29,7 @@ class Vector : public Matrix<Type, M, 1>
     {
     }
 
-    Vector(const Type data_[M]) :
+    explicit Vector(const Type data_[M]) :
         MatrixM1(data_)
     {
     }

matrix/Vector2.hpp

@@ -31,7 +31,7 @@ class Vector2 : public Vector<Type, 2>
     {
     }
 
-    Vector2(const Type data_[2]) :
+    explicit Vector2(const Type data_[2]) :
         Vector<Type, 2>(data_)
     {
     }

matrix/Vector3.hpp

@@ -39,7 +39,7 @@ class Vector3 : public Vector<Type, 3>
     {
     }
 
-    Vector3(const Type data_[3]) :
+    explicit Vector3(const Type data_[3]) :
         Vector<Type, 3>(data_)
     {
     }

test/attitude.cpp

@@ -4,11 +4,10 @@
 
 using namespace matrix;
 
-namespace matrix {
-
 // manually instantiated all files we intend to test
 // so that coverage works correctly
 // doesn't matter what test this is in
+namespace matrix {
 template class Matrix<float, 3, 3>;
 template class Vector3<float>;
 template class Vector2<float>;
@@ -17,13 +16,10 @@ template class Quaternion<float>;
 template class AxisAngle<float>;
 template class Scalar<float>;
 template class SquareMatrix<float, 4>;
-
 }
 
 int main()
 {
-
-
     // check data
     Eulerf euler_check(0.1f, 0.2f, 0.3f);
     Quatf q_check(0.98334744f, 0.0342708f, 0.10602051f, .14357218f);