Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modification of EST_BUF_SIZE at position_estimator_inav module #1738

Closed
stmoon opened this issue Feb 2, 2015 · 1 comment
Closed

modification of EST_BUF_SIZE at position_estimator_inav module #1738

stmoon opened this issue Feb 2, 2015 · 1 comment
Labels
Admin: Enhancement (improvement) 💡
Milestone
Release v1.2.0

Comments

@stmoon
Copy link
Contributor

stmoon commented Feb 2, 2015

Hi,,

While analyzing the position_estimator_inav module, I found the EST_BUF_SIZE is not correct.
The buffer was created for estimation of position and velocity by using GPS, flow, ....

The GPS and flow timeout is 0.5s. So... The buffer should store the estimated data at least during 0.5s.
However, the EST_BUF_SIZE is stored only during 0.25s.
so How about change the EST_BUF_SIZE 500000 / PUB_INTERVAL ?

Thanks in advance

Best Regards,
Moon

https://github.com/PX4/Firmware/blob/master/src/modules/position_estimator_inav/position_estimator_inav_main.c#L77

define PUB_INTERVAL 10000 // limit publish rate to 100 Hz

define EST_BUF_SIZE 250000 / PUB_INTERVAL // buffer size is 0.5s
@stmoon stmoon closed this as completed Feb 2, 2015
@stmoon stmoon changed the title How about modification of EST_BUF_SIZE at position_estimator_inav module Feb 2, 2015
@stmoon stmoon reopened this Feb 2, 2015
@LorenzMeier
Copy link
Member

Do you have further feedback / comments on this?

@LorenzMeier LorenzMeier added this to the 2nd Beta release milestone Jun 14, 2015
@LorenzMeier LorenzMeier reopened this Jun 14, 2015
PX4BuildBot added a commit that referenced this issue Nov 11, 2021
@PX4BuildBot
Update submodule mavlink to latest Thu Nov 11 12:39:05 UTC 2021
59276a7 
    - mavlink in PX4/Firmware (4661e63): mavlink/mavlink@0a728aa
    - mavlink current upstream: mavlink/mavlink@b354af1
    - Changes: mavlink/mavlink@0a728aa...b354af1

    b354af1c 2021-11-11 Beat Küng - add actuator test and configuration commands (#1738)
a8401492 2021-11-11 Beat Küng - Component information: add actuators (#1729)
PX4BuildBot added a commit that referenced this issue Nov 12, 2021
@PX4BuildBot
Update submodule mavlink to latest Fri Nov 12 00:39:17 UTC 2021
3203c0a 
    - mavlink in PX4/Firmware (0446510): mavlink/mavlink@0a728aa
    - mavlink current upstream: mavlink/mavlink@b354af1
    - Changes: mavlink/mavlink@0a728aa...b354af1

    b354af1c 2021-11-11 Beat Küng - add actuator test and configuration commands (#1738)
a8401492 2021-11-11 Beat Küng - Component information: add actuators (#1729)
PX4BuildBot added a commit that referenced this issue Nov 12, 2021
@PX4BuildBot
Update submodule mavlink to latest Fri Nov 12 12:38:59 UTC 2021
bf39d3f 
    - mavlink in PX4/Firmware (bad3c34): mavlink/mavlink@0a728aa
    - mavlink current upstream: mavlink/mavlink@b354af1
    - Changes: mavlink/mavlink@0a728aa...b354af1

    b354af1c 2021-11-11 Beat Küng - add actuator test and configuration commands (#1738)
a8401492 2021-11-11 Beat Küng - Component information: add actuators (#1729)
PX4BuildBot added a commit that referenced this issue Nov 15, 2021
@PX4BuildBot
Update submodule mavlink to latest Mon Nov 15 00:39:12 UTC 2021
060b905 
    - mavlink in PX4/Firmware (3fe9003): mavlink/mavlink@0a728aa
    - mavlink current upstream: mavlink/mavlink@c3a4b52
    - Changes: mavlink/mavlink@0a728aa...c3a4b52

    c3a4b52e 2021-11-14 olliw42 - use [value:] invalid attribute style (#1742)
5f353d79 2021-11-15 Hamish Willee - fix invalid attribute for arrays where first element sets as invalid (#1740)
b354af1c 2021-11-11 Beat Küng - add actuator test and configuration commands (#1738)
a8401492 2021-11-11 Beat Küng - Component information: add actuators (#1729)
PX4BuildBot added a commit that referenced this issue Nov 16, 2021
@PX4BuildBot
Update submodule mavlink to latest Tue Nov 16 00:39:28 UTC 2021
70fae71 
    - mavlink in PX4/Firmware (2615146): mavlink/mavlink@0a728aa
    - mavlink current upstream: mavlink/mavlink@c3a4b52
    - Changes: mavlink/mavlink@0a728aa...c3a4b52

    c3a4b52e 2021-11-14 olliw42 - use [value:] invalid attribute style (#1742)
5f353d79 2021-11-15 Hamish Willee - fix invalid attribute for arrays where first element sets as invalid (#1740)
b354af1c 2021-11-11 Beat Küng - add actuator test and configuration commands (#1738)
a8401492 2021-11-11 Beat Küng - Component information: add actuators (#1729)
@dagar dagar mentioned this issue Nov 16, 2021
Merged
dagar pushed a commit that referenced this issue Nov 16, 2021
@PX4BuildBot @dagar
Update submodule mavlink to latest Tue Nov 16 00:39:28 UTC 2021
bfcd251 
    - mavlink in PX4/Firmware (2615146): mavlink/mavlink@0a728aa
    - mavlink current upstream: mavlink/mavlink@c3a4b52
    - Changes: mavlink/mavlink@0a728aa...c3a4b52

    c3a4b52e 2021-11-14 olliw42 - use [value:] invalid attribute style (#1742)
5f353d79 2021-11-15 Hamish Willee - fix invalid attribute for arrays where first element sets as invalid (#1740)
b354af1c 2021-11-11 Beat Küng - add actuator test and configuration commands (#1738)
a8401492 2021-11-11 Beat Küng - Component information: add actuators (#1729)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Admin: Enhancement (improvement) 💡
Projects
None yet
Milestone
Release v1.2.0
Development

No branches or pull requests
2 participants
@LorenzMeier @stmoon