Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardware and Sensors #7648

Closed
mrpollo opened this issue Jul 19, 2017 · 6 comments
Closed

Hardware and Sensors #7648

mrpollo opened this issue Jul 19, 2017 · 6 comments
Labels
Admin: Enhancement (improvement) 💡 [ARCHIVED] rtps (depreciated) Documentation 📑 Anything improving the documentation of the code / ecosystem MAVROS

Comments

@mrpollo
Copy link
Contributor

mrpollo commented Jul 19, 2017

@TSC21
Copy link
Member

TSC21 commented Jul 19, 2017 •
edited
Loading

Hi guys. About this me @vilhjalmur89 are going to sync to push a lib to MAVROS that will serve as a bridge between PX4 msgs coming on fast-RTPS and translating them into ROS. This was something that probably pass through you as usually I am not able to attend to the dev meetings at thaf time. Is there someone else I should sync with to get this done? Marcus?
Also about MAVROS port to ROS 2.0 - that's also something on the maintainers TODO list.

@TSC21
Copy link
Member

TSC21 commented Jul 19, 2017

Also to inform that Jaime Losa, eProsima CEO, is aware of this integration effort.

@TSC21 TSC21 closed this as completed Jul 19, 2017
@TSC21 TSC21 reopened this Jul 19, 2017
@LorenzMeier
Copy link
Member

I've mentioned this a couple times, just making sure it does not drop: I think we should put some effort behind making sure that mavlink-router (serving as bridge to FastRTPS) and mavros can share as much code as possible on the serialisation part. They are doing the same task for much of what they execute and they should base of the same base serialisation library.

@TSC21
Copy link
Member

TSC21 commented Jul 19, 2017 •
edited
Loading

I agree with you. But talking with the mavlink-router team the answer I got was short and something as close as "we are commited to mavlink-router at the moment". So unless we sync efforts to have a common library for fast-RTPS (that can support both MAVLink and CDR msg translation) to have a common base for both MAVROS and mavlik-router, we are going to end-up having different libraries doing the same. On a purpose-base perspective, it can also make sense as mavlink-router is a more general bridge than MAVROS, which focus on translation for the ROS framework, and based on that perspective @vilhjalmur89 agreed also that MAVROS could have a module implemented (as libmavconn) that could wrap CDR from and to fast-RTPS.
Still, the serialization code would be really similar, while the translation would be different. So this is just to let know there's an effort on MAVROS side and mine so this can happen.

@PX4BuildBot
Copy link
Collaborator

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 30 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

@evercltech
Copy link

evercltech commented Feb 21, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Admin: Enhancement (improvement) 💡 [ARCHIVED] rtps (depreciated) Documentation 📑 Anything improving the documentation of the code / ecosystem MAVROS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mrpollo @LorenzMeier @evercltech @TSC21 @PX4BuildBot