Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtol tailsitter minor cleanup #11966

Closed

Conversation

dagar
Copy link
Member

@dagar dagar commented May 5, 2019

A few minor changes on top of #11911.

In the FW & MC controllers only grab the VT_TYPE once initially if a VTOL.

sfuhrer and others added 11 commits May 5, 2019 14:13
…responding (correct) attitude controller is running

Signed-off-by: Silvan Fuhrer <[email protected]>
- attitude setpoint for stabilized mode is generated by tailsitter.cpp
- reset yaw setpoint during transition to avoid big yaw errors after
transition back to hover

Signed-off-by: Roman <[email protected]>
…for some boards that don't support VTOL

Signed-off-by: Roman <[email protected]>
@dagar dagar requested a review from RomanBapst May 5, 2019 18:53
@dagar dagar force-pushed the pr-vtol_att_controller_new branch from 05b7195 to 24099af Compare May 5, 2019 18:54
@dagar dagar requested a review from julianoes May 5, 2019 18:55
@RomanBapst RomanBapst force-pushed the pr-vtol_att_controller_new branch from 358ab7b to 8934857 Compare May 5, 2019 19:26
@julianoes
Copy link
Contributor

This is a bit confusing. I've seen some of these changes before. And also it seems to conflict. I'm waiting with reviewing until this is a better state.

@dagar
Copy link
Member Author

dagar commented May 6, 2019

This is a bit confusing. I've seen some of these changes before. And also it seems to conflict. I'm waiting with reviewing until this is a better state.

I believe @RomanBapst manually dropped the changes into #11911, which is why the diff in this PR is now so messy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants