posix: restore original SEGV signal handler upon first entry of our handler #12099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andler The current SEGV handling on posix is not useful: as soon as our handler is left, it's triggered again, infinitely. This patch changes to restore the original handler, so the OS can create a core dump, etc.
I agree, let's remove it. |
julianoes
approved these changes
May 29, 2019
LorenzMeier
approved these changes
May 29, 2019
|
Yes I think it would be better removed entirely unless someone is going to invest effort into making it useful. |
I tried for a bit but I needed to use an external tool and it still was not foolproof to resolve the functions. I think it's better to just use gdb or look at the core files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current SEGV handling on posix is not useful: as soon as our handler is left, it's triggered again, infinitely.
This patch changes to restore the original handler, so the OS can create a core dump, etc.
I'm also ok with removing our custom handler altogether, since the stack trace addresses are not resolved to function names, and therefore not very useful.