Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools/setup.sh only install python3 dependencies #12112

Merged
merged 1 commit into from
May 30, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented May 30, 2019

Also made a few other improvements to make it easier and safer to repeatedly rerun the script.

@dagar dagar merged commit 4b3f68f into PX4:master May 30, 2019
@dagar dagar deleted the pr-tools_setup_python3 branch May 30, 2019 00:48
@hamishwillee
Copy link
Contributor

@dagar I still haven't tested this in anger. Do you think that we're at the point where these might replace many of the devguide scripts?

@dagar
Copy link
Member Author

dagar commented May 30, 2019

The CI system uses them for "production builds" and I use them for real on Ubuntu (at least current LTS) and MacOS. I think we'd have to do a quick pass to check for parity. Off the top of my head they're still missing FastRTPS, but I think until there's more traction (or a clean package) that could be a standalone set of instructions (a few lines).

@hamishwillee
Copy link
Contributor

I think until there's more traction (or a clean package) that could be a standalone set of instructions (a few lines).

Does that mean yes or no? (could be either, but I "think" probably it means that "you can use this now if you don't need FastRTPS, and the process would be easier that what we currently have")

@dagar
Copy link
Member Author

dagar commented May 30, 2019

It's a yes, but it may not be 100% identical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants