Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EKF2 move most orb subscriptions to uORB::Subscription #12118

Merged
merged 1 commit into from
Jun 6, 2019
Merged

EKF2 move most orb subscriptions to uORB::Subscription #12118

merged 1 commit into from
Jun 6, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented May 30, 2019 •
edited by AuterionWrikeBot
Loading

Requires #12040 before merging.

@dagar dagar added this to the Release v1.10.0 milestone May 30, 2019
@dagar dagar force-pushed the pr-ekf2_subscription branch from 671fa11 to f9c9801 Compare May 30, 2019 19:49
@weekly-digest weekly-digest bot mentioned this pull request Jun 2, 2019
Closed
@dagar dagar force-pushed the pr-ekf2_subscription branch from f9c9801 to 5a0e59c Compare June 3, 2019 21:35
@dagar dagar marked this pull request as ready for review June 3, 2019 21:35
@dagar
Copy link
Member Author

dagar commented Jun 3, 2019

Ready for review and testing.

@dagar dagar force-pushed the pr-ekf2_subscription branch from 5a0e59c to bec5e4b Compare June 4, 2019 14:55
@dagar dagar requested review from a team and julianoes June 4, 2019 14:56
@jorge789
Copy link

jorge789 commented Jun 5, 2019

Tested on Pixhawk 4 V5

Modes Tested

Position Mode: Good.
Altitude Mode: Good.
Stabilized Mode: Good.
Mission Plan Mode (Automated): Good.
RTL: Good.

- Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoin activate RTL and see landing behaviour.

Notes:
No issues noted, good flight in general.

Logs:
https://review.px4.io/plot_app?log=26917c92-5aa0-4c10-bb11-a1ebebb5770f

https://review.px4.io/plot_app?log=cec863bf-1fcb-4dd5-b0d1-27673d50de96

COMPARISON OF MASTER :
https://review.px4.io/plot_app?log=1411598d-8567-48fc-844e-6a54d9b302a4

@dagar dagar force-pushed the pr-ekf2_subscription branch from bec5e4b to 8408d67 Compare June 6, 2019 01:25
@julianoes julianoes merged commit 3796dda into PX4:master Jun 6, 2019
@dagar dagar deleted the pr-ekf2_subscription branch June 6, 2019 13:17
@weekly-digest weekly-digest bot mentioned this pull request Jun 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianoes julianoes julianoes approved these changes

Assignees
No one assigned
Labels
Admin: Cleanup (housekeeping) 🧹 Admin: Enhancement (improvement) 💡
Projects
None yet
Milestone
Release v1.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dagar @jorge789 @julianoes