Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtol_att_control move to WQ with uORB callback scheduling #12229

Merged

Conversation

dagar
Copy link
Member

@dagar dagar commented Jun 10, 2019

Requires #12207 before merging.
Background - #12207

@dagar dagar changed the title vtol_att_control move to WQ with uORB callback scheduling [WIP]: vtol_att_control move to WQ with uORB callback scheduling Jun 10, 2019
@dagar dagar force-pushed the pr-orb_subscription_callback branch 3 times, most recently from 312999b to a67e42b Compare June 13, 2019 18:07
@dagar dagar force-pushed the pr-orb_subscription_callback-vtol_att_control branch from 7bc2cf1 to d4e9b04 Compare June 13, 2019 18:30
@dagar dagar changed the base branch from pr-orb_subscription_callback to master June 17, 2019 20:23
@dagar dagar changed the title [WIP]: vtol_att_control move to WQ with uORB callback scheduling vtol_att_control move to WQ with uORB callback scheduling Jun 17, 2019
@dagar dagar force-pushed the pr-orb_subscription_callback-vtol_att_control branch from d4e9b04 to 7060225 Compare June 17, 2019 20:23
@dagar dagar marked this pull request as ready for review June 17, 2019 20:23
@dagar dagar requested review from a team and RomanBapst June 17, 2019 20:24
@dannyfpv
Copy link

dannyfpv commented Jun 19, 2019

tested on Pixhawk4 mini V5 v-tol
Modes Tested

mission Mode: no issue
Altitude Mode: no issue
Stabilized Mode: no issue
land mode: no issue
pr log:
https://review.px4.io/plot_app?log=59aa9861-a0c8-4f15-aec5-61e3e39be905
master log:
https://review.px4.io/plot_app?log=1c38da3d-622f-4c2b-b526-e1435c0867e7

@dagar dagar force-pushed the pr-orb_subscription_callback-vtol_att_control branch 2 times, most recently from 551b251 to 5033f08 Compare July 1, 2019 17:20
@dagar dagar force-pushed the pr-orb_subscription_callback-vtol_att_control branch 2 times, most recently from 49b7398 to 1817231 Compare August 6, 2019 18:35
@dagar dagar force-pushed the pr-orb_subscription_callback-vtol_att_control branch from 1817231 to 3ccf222 Compare August 7, 2019 02:12
@dagar dagar added this to the Release v1.10.0 milestone Aug 7, 2019
@dagar dagar force-pushed the pr-orb_subscription_callback-vtol_att_control branch from 35632cc to 5f63ba3 Compare August 8, 2019 03:22
@dagar dagar force-pushed the pr-orb_subscription_callback-vtol_att_control branch from 5f63ba3 to 61d728d Compare August 8, 2019 03:28
@dagar
Copy link
Member Author

dagar commented Aug 8, 2019

@PX4/testflights could you give this one another go?
@RomanBapst @sfuhrer if you're flying VTOL in the near future could you give this a quick flight as well?

Other than potential regressions the thing I'd like to review is cpu and memory usage (vs master as of a few days ago) and end-to-end latency for both the FW and MC actuators.

@sfuhrer
Copy link
Contributor

sfuhrer commented Aug 9, 2019

@PX4/testflights could you give this one another go?
@RomanBapst @sfuhrer if you're flying VTOL in the near future could you give this a quick flight as well?

Other than potential regressions the thing I'd like to review is cpu and memory usage (vs master as of a few days ago) and end-to-end latency for both the FW and MC actuators.

@dagar Tested on our FunCub VTOL (Pixhawk4, quadplane). Flew MC/FW in stab and pos. Felt as always. log:
https://review.px4.io/plot_app?log=2bfa950a-80b7-45d2-bf22-b581c683a067

@dagar
Copy link
Member Author

dagar commented Aug 9, 2019

Thanks @sfuhrer. I did a quick comparison with 2 other logs from the same vehicle (testing #12626)

Differences I noticed.

  • overall cpu usage down slightly (maybe a couple percent)
  • px4io control latency (MAIN outputs) about the same
  • px4fmu control latency (AUX outputs) down significantly (> 4000 us to ~700 us)
  • memory usage reduced by somewhere around 17 kB (this is a huge chunk for older boards)

@dagar dagar merged commit b5a0153 into PX4:master Aug 9, 2019
@dagar dagar deleted the pr-orb_subscription_callback-vtol_att_control branch August 9, 2019 16:44
bozkurthan pushed a commit to bozkurthan/Firmware that referenced this pull request Sep 4, 2019
* add perf counters for cycle time and interval
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants