Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IntrusiveQueue add remove method, iterators, and update test #12246

Merged
merged 3 commits into from
Jun 13, 2019
Merged

IntrusiveQueue add remove method, iterators, and update test #12246

merged 3 commits into from
Jun 13, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented Jun 11, 2019

No description provided.

@dagar dagar mentioned this pull request Jun 11, 2019
Merged
@dagar dagar force-pushed the pr-queue_remove branch from 35d424b to eb79882 Compare June 11, 2019 19:19
@dagar dagar requested a review from julianoes June 11, 2019 19:24
@dagar dagar force-pushed the pr-queue_remove branch from eb79882 to 79689a0 Compare June 12, 2019 02:08
julianoes
julianoes reviewed Jun 12, 2019
View reviewed changes
src/include/containers/BlockingList.hpp
@@ -68,7 +68,7 @@ class BlockingList : public List<T>
return List<T>::remove(removeNode);
}

size_t size() const
size_t size()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can make _mutex mutable to leave const.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, you're prompting good const correctness questions.

src/systemcmds/tests/test_IntrusiveQueue.cpp Show resolved Hide resolved
julianoes
julianoes approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok that's better.

@dagar dagar merged commit a4a130f into PX4:master Jun 13, 2019
@dagar dagar deleted the pr-queue_remove branch June 13, 2019 14:47
@weekly-digest weekly-digest bot mentioned this pull request Jun 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianoes julianoes julianoes approved these changes

Assignees
No one assigned
Labels
Admin: Enhancement (improvement) 💡
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagar @julianoes