VTOL: keep status (MC/FW) when switching out of mission mode #12684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing out of mission into manual mode, but keep current VTOL status (MC or FW) until transition switch is moved to the opposite position. Signed-off-by: Silvan Fuhrer <[email protected]>
sfuhrer
added
Admin: Enhancement (improvement) 💡
Hybrid VTOL 🛩️🚁
|
@sfuhrer Can you either update http://docs.px4.io/master/en/flight_modes/mission.html#description with this information or ping me when this is merged? Note that it is not entirely obvious where you would put the info. I think I'd start by adding a section for VTOL and seeding it with the text from the current description: "VTOL vehicles follow the behavior and parameters of fixed-wing when in FW mode, and of copter when in MC mode." ... then describe this feature. |
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by the proposed pull request
Addresses #12680.
With this PR it is no longer the position of transition switch that sets the VTOL status when changing out of mission into manual mode, but the current VTOL status (MC or FW) is kept until the transition switch is moved to the position that is mapped to the opposite VTOL status.
Test data / coverage
Only SITL tested yet (and there the problem described in #12680 is anyway not reproducible, as the transition switch on a joystick is doesn't have states but only triggers events)