commander: fix arming auth param translation #12698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The int32 param COM_ARM_AUTH is mapped to a packed struct. However, this struct was not actually packed (anymore) and therefore the values were applied incorrectly. I fixed this by applying the packed attribute. By using a union with a int32_t I could rid of the warning about address-of-packed-member.
When we send a command to any sysid or any compid, we need to match an ack from a specific sysid or compid. If we don't do that, we keep sending retransmissions and eventually time out.
dagar
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The int32 param COM_ARM_AUTH is mapped to a packed struct. However, this struct was not actually packed (anymore) and therefore the values were applied incorrectly.
I fixed this by applying the packed attribute. By using a union with a int32_t I could rid of the warning about address-of-packed-member.
This also fixes the issue where sysid and compid in the mavlink_command_sender do not match because the target_system and target_component are 0 (to all). This meant that the command was being re-transmitted multiple times even though an ack was received.
Tested in SITL so far.
Fixes #12685.