ACTUATOR_OUTPUT_STATUS MAVLink stream for ESCs #13145
Conversation
| esc_status_s esc_status; | ||
|
|
||
| if (_esc_status_sub->update(&_esc_status_time, &esc_status)) { | ||
| mavlink_actuator_output_status_t msg = {}; |
There was a problem hiding this comment.
@hamishwillee Is that message supposed to contain the feedback from the actuators? It's not clear to me from the message spec.
There was a problem hiding this comment.
IMO ACTUATOR_OUTPUT_STATUS message should provide feedback from the actuators because of we can receive controls with ACTUATOR_CONTROL_TARGET message.
There was a problem hiding this comment.
@bkueng It is the updated version of SERVO_OUTPUT_RAW. Discussed in mavlink/mavlink#926
So my understanding is that this is just the raw PWM values we are outputing on all MAIN, AUX, whatever. Not feedback from actuator.
Can you review that chain and confirm you agree. If so, I will add note to it saying this.
There was a problem hiding this comment.
That was my understanding as well.
However that means the implementation here is not correct.
There was a problem hiding this comment.
@irsdkv ACTUATOR_CONTROL_TARGET contains the values before the mixing.
There was a problem hiding this comment.
@bkueng Cool, Assigned you clarification for review: mavlink/mavlink#1252
There was a problem hiding this comment.
@bkueng so is this PR now correct or not? I'm confused.
There was a problem hiding this comment.
@bkueng so is this PR now correct or not? I'm confused.
It's not. I thought I wrote that?
There was a problem hiding this comment.
@irsdkv have you fixed the issue raised here?
There was a problem hiding this comment.
@julianoes I'm still confused.
What I should fix?
|
Errors: Should I do anything else so that you can merge PR? |
|
What's the status of this? Is a new mavlink message needed? Would be nice to have this in the release. |
Yes, I don't see anything existing. |
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
Adding ACTUATOR_OUTPUT_STATUS Mavlink stream for UAVs with ESCs.
Test data / coverage
Tested with MAVSDK (This PR).