Replay: support dual gps replay #14092
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlOlsson
changed the title
|
Did you see the build failure? |
Sorry, forgot to compile it for SITL |
|
As discussed on Slack, let's first look at the root of the problem(s). |
|
replaced by #14114 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
Support secondary GPS module in ekf2 replay. Solves #13953.
Describe your solution
Add relative timestamps to secondary GPS and handle it as any other sensor
Describe possible alternatives
According to this PR support for a second GPS module was already added but I don't understand how it could have been working properly prior to this PR
Test data / coverage
Code has been tested on code similar to v1.10.1
Additional context
This code treats the secondary GPS module in the same way as the primary one. It does not solve the second issue mentioned in the issue above related to timeouts.