accel and gyro calibration cleanup #14237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
force-pushed
the
pr-sensors_accel_gyro_calibration_cleanup
branch
from
4824993 to
9b12e30
Compare
dagar
commented
Feb 25, 2020
| @@ -52,6 +52,14 @@ class ModuleParams : public ListNode<ModuleParams *> | |||
| setParent(parent); | |||
| } | |||
|
|
|||
| // empty copy and move constructors (don't copy _children) | |||
| ModuleParams(const ModuleParams &) {}; | |||
dagar
commented
Feb 25, 2020
dagar
force-pushed
the
pr-sensors_accel_gyro_calibration_cleanup
branch
from
f8d0d77 to
30132a1
Compare
dagar
force-pushed
the
pr-sensors_accel_gyro_calibration_cleanup
branch
8 times, most recently
from
1d1a985 to
4ec552a
Compare
dagar
added
Admin: Cleanup (housekeeping) 🧹
Drivers 🔧
dagar
force-pushed
the
pr-sensors_accel_gyro_calibration_cleanup
branch
2 times, most recently
from
1394c1f to
a7e1b82
Compare
- kill IOCTLs for accel and gyro calibration - move accel/calibration entirely to sensors module
dagar
force-pushed
the
pr-sensors_accel_gyro_calibration_cleanup
branch
from
a7e1b82 to
2f63346
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other than cleanup, the motivation for this change is to allow the filtered angular velocity (and acceleration) to be computed directly from the raw sensor data array (FIFO) when it's available.