add new rotation #14512
add new rotation #14512
Conversation
fix compile error fix rotation modify roatation
jinchengde
force-pushed
the
pr-new-rotation
branch
from
555ad5a to
44a8b59
Compare
|
I'm wondering if there's value in trying to keep in sync with mavlink? https://mavlink.io/en/messages/common.html#MAV_SENSOR_ORIENTATION |
|
@dagar yes, be careful that the current implementation assumes that enum values are consecutive, without gap. I was tricked last time I added a rotation following MAVLink's enum, which was not equal to last enum value +1. I finally added the rotation at the end of the PX4 enum by pure lazyness. |
|
and the rotation enum is so disarray, do you wish to arrange? |
|
@jinchengde I think we need this one: mavlink/mavlink#1348 |
|
@jinchengde could you update this based on mavlink/mavlink#1348 ? |
|
@julianoes do you mean modify the enum to 41? |
|
Yes, thanks @jinchengde. And it would be nice to also update the mavlink (c_library_v2) submodule to latest master. |
|
Nevermind, this is already done in #14725. |
|
The table (rot_lookup[]) needs to align with the enum. Let's quickly add the missing rotations from mavlink.
I'm also starting to think we'd be better abstracting the mavlink constants entirely from PX4, but that's a messy change. |
* add new rotation ROLL_270_YAW_180 fix compile error fix rotation modify roatation * modify enum to 41
I haven't find any rotation for ROLL_270_YAW_180, add it