Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up doc links to point to master branch #14709

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Fix up doc links to point to master branch #14709

merged 1 commit into from
Apr 21, 2020

Conversation

hamishwillee
Copy link
Contributor

The old link format goes to a redirect, which takes you to the v1.9 version of the docs. I think linking explicitly to docs master branch is generally better.

@hamishwillee hamishwillee requested a review from bkueng April 20, 2020 01:24
@hamishwillee
Copy link
Contributor Author

Can whoever approves this also merge it. I don't have rights.

@julianoes
Copy link
Contributor

@hamishwillee on that. Why do the default links redirect to 1.9? Why isn't the default 1.10 aka current stable?

@hamishwillee
Copy link
Contributor Author

hamishwillee commented Apr 21, 2020

Can you merge this. I don't have the rights. Should be done irrespective of discussion below.

Why do the default links redirect to 1.9? Why isn't the default 1.10 aka current stable?

@julianoes The redirect to v1.9 not because it was the stable release at the time I did this, but because I wanted to ensure that the maximum number of existing external links to the old "bare URLs" would go to actual pages and not pages that got moved/deleted over time - as would be the case if I used master.

Over time I hoped there would be fewer and fewer links going to the old non-specific URL. I would prefer not to update to v1.10 - it is yet another step that needs to be maintained.

Maybe fixing these up to point to master and be done with it would be better that v1.9, or trying to track stable. Do you have an opinion?

@bkueng bkueng merged commit 8236b8d into PX4:master Apr 21, 2020
@julianoes
Copy link
Contributor

Maybe fixing these up to point to master and be done with it would be better that v1.9, or trying to track stable. Do you have an opinion?

Agreed.

@hamishwillee hamishwillee deleted the doclinkfix branch April 22, 2020 23:54
@hamishwillee
Copy link
Contributor Author

Thanks Julian. On my list to change it "soon". Bit overloaded right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants